Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BlockChain<T>.Contains(TxId) to IStore #676

Merged

Conversation

@longfin
Copy link
Member

longfin commented Nov 14, 2019

This PR moves BlockChain<T>.Contains(TxId) to IStore to separate the global transaction view from BlockChain<T>.

@longfin longfin marked this pull request as ready for review Nov 14, 2019
@longfin longfin requested review from dahlia, earlbread and limebell Nov 14, 2019
CHANGES.md Outdated Show resolved Hide resolved
@longfin longfin requested review from dahlia and moreal Nov 14, 2019
CHANGES.md Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #676 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff            @@
##           master    #676      +/-   ##
=========================================
- Coverage   87.31%   87.3%   -0.02%     
=========================================
  Files         218     218              
  Lines       17781   17789       +8     
=========================================
+ Hits        15526   15531       +5     
- Misses       1193    1196       +3     
  Partials     1062    1062
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.94% <ø> (-0.06%) ⬇️
Libplanet.Tests/Store/StoreTracker.cs 55.55% <0%> (-1.59%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.63% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 96.95% <100%> (+0.03%) ⬆️
Libplanet/Store/DefaultStore.cs 82.85% <100%> (+0.21%) ⬆️
Libplanet/Store/TransactionSet.cs 84.61% <50%> (ø) ⬆️
Libplanet/Net/Swarm.cs 86.02% <83.33%> (+0.03%) ⬆️
@longfin longfin force-pushed the longfin:feature/seperate-contains-from-chain branch from 227eff2 to ffd81d1 Nov 14, 2019
@longfin longfin requested a review from earlbread Nov 14, 2019
@longfin longfin force-pushed the longfin:feature/seperate-contains-from-chain branch from ffd81d1 to 5589844 Nov 14, 2019
@longfin longfin requested a review from limebell Nov 14, 2019
@longfin longfin self-assigned this Nov 14, 2019
@longfin longfin merged commit 0d84f4c into planetarium:master Nov 14, 2019
19 of 20 checks passed
19 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 80% of diff hit (target 87.31%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.3% (-0.02%) compared to ba6e84d
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191114.11 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.