Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of AddresStateMap #692

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

@dahlia
Copy link
Member

dahlia commented Nov 25, 2019

Fixed #98.

Fix #98
@dahlia dahlia added the suggestion label Nov 25, 2019
@dahlia dahlia added this to the 0.8.0 milestone Nov 25, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Nov 25, 2019
@dahlia dahlia self-assigned this Nov 25, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #692 into master will increase coverage by 0.02%.
The diff coverage is 93.93%.

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   86.12%   86.15%   +0.02%     
==========================================
  Files         221      220       -1     
  Lines       18116    18037      -79     
==========================================
- Hits        15602    15539      -63     
+ Misses       1449     1425      -24     
- Partials     1065     1073       +8
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTracker.cs 56.75% <ø> (ø) ⬆️
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet/Serialization/BencodexFormatter.cs 66.46% <0%> (-3.05%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.62% <100%> (-0.01%) ⬇️
Libplanet/Net/Swarm.cs 81.46% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.09% <100%> (-0.01%) ⬇️
Libplanet/Store/DefaultStore.cs 87.08% <100%> (+0.28%) ⬆️
Libplanet/Blockchain/BlockChain.cs 93.01% <90%> (-0.2%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 95.59% <94.44%> (-0.14%) ⬇️
Copy link
Contributor

moreal left a comment

Awesome! But I think it's better to change them for the new version of bencodex.net!

Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated Show resolved Hide resolved
Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated Show resolved Hide resolved
Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated Show resolved Hide resolved
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
@dahlia dahlia requested a review from moreal Nov 25, 2019
@moreal
moreal approved these changes Nov 25, 2019
@dahlia dahlia merged commit 072d6f4 into planetarium:master Nov 25, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 93.93% of diff hit (target 86.12%)
Details
codecov/project 86.15% (+0.02%) compared to 3597c5a
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191125.9 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.