Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PreloadBlockDownloadFailed event handler #694

Merged
merged 5 commits into from Dec 2, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Nov 26, 2019

When the block downloading fails in Swarm<T>.PreloadAsync, Swarm<T> became to call Swarm<T>.PreloadBlockDownloadFailed event handler. If the event handler doesn't exist, Swarm<T> throws SwarmException.

@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Nov 26, 2019
@earlbread earlbread self-assigned this Nov 26, 2019
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 4be86af to 7dd35f9 Nov 26, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #694 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #694     +/-   ##
=========================================
+ Coverage   86.11%   86.21%   +0.1%     
=========================================
  Files         220      221      +1     
  Lines       18096    18134     +38     
=========================================
+ Hits        15583    15634     +51     
+ Misses       1441     1426     -15     
- Partials     1072     1074      +2
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 81.8% <100%> (+0.32%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 95.8% <100%> (+0.08%) ⬆️
Libplanet/Net/PreloadBlockDownloadFailEventArgs.cs 100% <100%> (ø)
Libplanet.Tests/Net/Protocols/TestSwarm.cs 79.63% <0%> (+0.9%) ⬆️
Libplanet/Store/DefaultStore.cs 85.65% <0%> (+1.14%) ⬆️
@earlbread earlbread requested review from dahlia Nov 26, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 7dd35f9 to 1b9415c Nov 26, 2019
@earlbread earlbread requested a review from dahlia Nov 26, 2019
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@earlbread earlbread requested a review from dahlia Nov 26, 2019
@earlbread earlbread dismissed stale reviews from moreal, limebell, and dahlia via 55d3ac6 Nov 28, 2019
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 304bd20 to 55d3ac6 Nov 28, 2019
@earlbread earlbread requested review from limebell, dahlia and moreal Nov 28, 2019
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 1a7555f to e989ee4 Nov 28, 2019
@earlbread earlbread dismissed stale reviews from longfin and dahlia via e614ba1 Nov 28, 2019
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from e989ee4 to e614ba1 Nov 28, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@earlbread earlbread requested a review from moreal Nov 28, 2019
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 2ca1830 to 9b24187 Nov 28, 2019
@earlbread earlbread requested review from dahlia and longfin Nov 29, 2019
@earlbread earlbread requested review from moreal and removed request for moreal Nov 29, 2019
earlbread and others added 5 commits Nov 26, 2019
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
Co-Authored-By: Lee Dogeon <dogeonlove0326@gmail.com>
@earlbread earlbread dismissed stale reviews from longfin and dahlia via d6fe8ac Dec 2, 2019
@earlbread earlbread force-pushed the earlbread:preload-failed-event branch from 9b24187 to d6fe8ac Dec 2, 2019
@earlbread earlbread requested review from dahlia and longfin Dec 2, 2019
@longfin
longfin approved these changes Dec 2, 2019
@moreal
moreal approved these changes Dec 2, 2019
@earlbread earlbread merged commit 7daa2f6 into planetarium:master Dec 2, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.11%)
Details
codecov/project 86.21% (+0.1%) compared to 50ecb5b
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191202.4 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:preload-failed-event branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.