Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ListAllStateReferences performance #701

Merged
merged 3 commits into from Dec 3, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Dec 2, 2019

This moves StoreExtension.ListAllStateReferences to IStore.ListAllStateReferences and improve the preformance of the method.

@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Dec 2, 2019
@earlbread earlbread self-assigned this Dec 2, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #701 into master will decrease coverage by 0.08%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   86.23%   86.14%   -0.09%     
==========================================
  Files         221      221              
  Lines       18134    18131       -3     
==========================================
- Hits        15637    15619      -18     
- Misses       1423     1438      +15     
  Partials     1074     1074
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreExtensionTest.cs 100% <ø> (ø) ⬆️
Libplanet/Store/StoreExtension.cs 71.42% <ø> (-23.31%) ⬇️
Libplanet.Tests/Store/StoreTracker.cs 55.26% <0%> (-1.5%) ⬇️
Libplanet.Tests/Store/StoreTest.cs 98.21% <100%> (+0.12%) ⬆️
Libplanet/Store/DefaultStore.cs 85.19% <100%> (-0.47%) ⬇️
Libplanet/Net/Protocols/KBucket.cs 90.99% <0%> (-2.71%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 95.69% <0%> (-0.12%) ⬇️
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:list-all-state-ref branch from 1cb5456 to 4da4705 Dec 2, 2019
Libplanet.Tests/Store/StoreTracker.cs Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:list-all-state-ref branch 2 times, most recently from c6d6726 to ab78000 Dec 2, 2019
@longfin longfin requested review from dahlia, limebell and moreal Dec 3, 2019
@earlbread earlbread dismissed stale reviews from moreal and longfin via c219844 Dec 3, 2019
@earlbread earlbread force-pushed the earlbread:list-all-state-ref branch from ab78000 to c219844 Dec 3, 2019
@earlbread earlbread force-pushed the earlbread:list-all-state-ref branch from c219844 to 3f6216d Dec 3, 2019
@earlbread earlbread requested review from longfin and moreal Dec 3, 2019
@longfin
longfin approved these changes Dec 3, 2019
@dahlia
dahlia approved these changes Dec 3, 2019
@moreal
moreal approved these changes Dec 3, 2019
@earlbread earlbread merged commit e7cc62c into planetarium:master Dec 3, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 94.59% of diff hit (target 86.23%)
Details
codecov/project Absolute coverage decreased by -0.08% but relative coverage increased by +8.36% compared to f21d105
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191203.5 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:list-all-state-ref branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.