Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm<T>.TransferRecentStates became not to send whole states. #703

Merged
merged 14 commits into from Dec 6, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Dec 3, 2019

Instead, it looks up some range of block indexes and send.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Dec 3, 2019
@limebell limebell self-assigned this Dec 3, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #703 into master will increase coverage by 0.01%.
The diff coverage is 90.65%.

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage    85.9%   85.92%   +0.01%     
==========================================
  Files         222      221       -1     
  Lines       18356    18642     +286     
==========================================
+ Hits        15769    16018     +249     
- Misses       1459     1469      +10     
- Partials     1128     1155      +27
Impacted Files Coverage Δ
Libplanet/Net/Protocols/KademliaProtocol.cs 65.78% <ø> (+0.52%) ⬆️
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 55.26% <0%> (ø) ⬆️
Libplanet/Net/StateDownloadState.cs 100% <100%> (ø)
Libplanet/Net/Messages/RecentStates.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.24% <100%> (ø) ⬆️
Libplanet.Tests/Net/Protocols/ProtocolTest.cs 100% <100%> (ø) ⬆️
Libplanet/Store/DefaultStore.cs 85.61% <100%> (-0.21%) ⬇️
Libplanet/Net/Messages/GetRecentStates.cs 100% <100%> (ø) ⬆️
Libplanet.Tests/Net/Messages/RecentStatesTest.cs 88.97% <60%> (-3.09%) ⬇️
... and 7 more
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Show resolved Hide resolved
@limebell limebell force-pushed the limebell:stateref-devide branch 5 times, most recently from 03613d0 to d41d27a Dec 3, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch from d41d27a to df468e6 Dec 4, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:stateref-devide branch 5 times, most recently from eb3dcf5 to f5a037b Dec 5, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch 3 times, most recently from cbd52a1 to 29bc426 Dec 5, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch 2 times, most recently from e1c7980 to 4729585 Dec 6, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch from 4729585 to d3ea743 Dec 6, 2019
@limebell limebell requested review from longfin, dahlia and earlbread Dec 6, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch from d3ea743 to a331aa0 Dec 6, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch from a331aa0 to da7514e Dec 6, 2019
@limebell limebell requested review from longfin and earlbread Dec 6, 2019
@limebell limebell dismissed stale reviews from longfin, moreal, and earlbread via 3a309e5 Dec 6, 2019
@limebell limebell force-pushed the limebell:stateref-devide branch from da7514e to 3a309e5 Dec 6, 2019
@dahlia
dahlia approved these changes Dec 6, 2019
@longfin
longfin approved these changes Dec 6, 2019
@longfin longfin merged commit 928225b into planetarium:master Dec 6, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 90.65% of diff hit (target 85.9%)
Details
codecov/project 85.92% (+0.01%) compared to f46529a
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191206.14 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.