Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state ref even if block state exists #704

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Dec 4, 2019

Fixed a bug where the state reference would not be updated when forking a chain and adding existed blocks.

@earlbread earlbread added the bug label Dec 4, 2019
@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Dec 4, 2019
@earlbread earlbread self-assigned this Dec 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #704 into master will increase coverage by 0.02%.
The diff coverage is 91.3%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   85.86%   85.89%   +0.02%     
==========================================
  Files         222      222              
  Lines       18332    18356      +24     
==========================================
+ Hits        15741    15767      +26     
+ Misses       1463     1461       -2     
  Partials     1128     1128
Impacted Files Coverage Δ
Libplanet/Store/DefaultStore.cs 85.81% <100%> (+0.12%) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.65% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 90.88% <80.95%> (ø) ⬆️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 79.63% <0%> (+0.9%) ⬆️
CHANGES.md Outdated Show resolved Hide resolved
@earlbread earlbread dismissed stale reviews from dahlia, moreal, and longfin via 6e9fca1 Dec 5, 2019
@earlbread earlbread force-pushed the earlbread:fix-setstate-after-fork branch from 705dacf to 6e9fca1 Dec 5, 2019
@earlbread

This comment has been minimized.

Copy link
Member Author

earlbread commented Dec 5, 2019

I fixed ForkStateReferences not to copy state references of the genesis block.

@earlbread earlbread requested review from dahlia, moreal and longfin Dec 5, 2019
@longfin
longfin approved these changes Dec 5, 2019
@dahlia
dahlia approved these changes Dec 5, 2019
@moreal
moreal approved these changes Dec 5, 2019
@earlbread earlbread merged commit 9cf9f3d into planetarium:master Dec 5, 2019
20 of 21 checks passed
20 of 21 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage failed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 91.3% of diff hit (target 85.86%)
Details
codecov/project 85.89% (+0.02%) compared to f762de3
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191205.1 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:fix-setstate-after-fork branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.