Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit state transfer log on debug #706

Merged
merged 2 commits into from Dec 4, 2019
Merged

Conversation

@longfin
Copy link
Member

longfin commented Dec 4, 2019

This PR adjusts the logging level(DebugVerbose) of some log messages related to state transfer.

@longfin longfin force-pushed the longfin:feature/swarm-log branch from 6e1da9b to 1c34861 Dec 4, 2019
@longfin longfin requested review from dahlia, moreal, limebell and earlbread and removed request for moreal Dec 4, 2019
@longfin longfin self-assigned this Dec 4, 2019
@longfin longfin marked this pull request as ready for review Dec 4, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #706 into master will decrease coverage by 2.21%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
- Coverage    85.9%   83.69%   -2.22%     
==========================================
  Files         222      198      -24     
  Lines       18332    17651     -681     
==========================================
- Hits        15749    14773     -976     
- Misses       1455     1765     +310     
+ Partials     1128     1113      -15
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 80.37% <75%> (ø) ⬆️
Libplanet.Stun/Stun/Attributes/ErrorCode.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Lifetime.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Nonce.cs 0% <0%> (-100%) ⬇️
...anet.Stun/Stun/Messages/CreatePermissionRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/Realm.cs 0% <0%> (-100%) ⬇️
...planet.Stun/Stun/Messages/ConnectionBindRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/ConnectionId.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Messages/AllocateRequest.cs 0% <0%> (-100%) ⬇️
Libplanet.Stun/Stun/Attributes/MessageIntegrity.cs 0% <0%> (-100%) ⬇️
... and 37 more
CHANGES.md Outdated Show resolved Hide resolved
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@longfin longfin dismissed stale reviews from moreal, limebell, and earlbread via e3b095e Dec 4, 2019
@dahlia
dahlia approved these changes Dec 4, 2019
@longfin longfin merged commit f762de3 into planetarium:master Dec 4, 2019
18 of 20 checks passed
18 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 75% of diff hit (target 85.9%)
Details
codecov/project 83.69% (-2.22%) compared to a1be3d0
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191204.12 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.