Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some bugs in Swarm<T> #709

Merged
merged 6 commits into from Dec 6, 2019
Merged

Conversation

@longfin
Copy link
Member

longfin commented Dec 6, 2019

This PR aids some bugs in Swarm<T> and loosen timeout value. (see changelog)

@longfin longfin self-assigned this Dec 6, 2019
@longfin longfin force-pushed the longfin:feature/swarm-tune branch from 7276733 to c105fad Dec 6, 2019
@longfin longfin requested review from dahlia, earlbread, moreal and limebell and removed request for dahlia Dec 6, 2019
@longfin longfin marked this pull request as ready for review Dec 6, 2019
@longfin longfin added the bug label Dec 6, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #709 into master will decrease coverage by 0.12%.
The diff coverage is 43.13%.

@@            Coverage Diff            @@
##           master    #709      +/-   ##
=========================================
- Coverage   85.92%   85.8%   -0.13%     
=========================================
  Files         221     221              
  Lines       18642   18677      +35     
=========================================
+ Hits        16019   16025       +6     
- Misses       1467    1496      +29     
  Partials     1156    1156
Impacted Files Coverage Δ
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (ø) ⬆️
Libplanet/Net/Swarm.cs 78.47% <45.83%> (-1.2%) ⬇️
Libplanet/Net/NetMQSocketExtension.cs 77.55% <0%> (-4.09%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
Libplanet/Net/Protocols/KBucket.cs 93.69% <0%> (+2.7%) ⬆️
@longfin longfin force-pushed the longfin:feature/swarm-tune branch from c105fad to 5eb6446 Dec 6, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@longfin longfin force-pushed the longfin:feature/swarm-tune branch from 5eb6446 to f604f26 Dec 6, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@longfin longfin force-pushed the longfin:feature/swarm-tune branch from 94dfe5c to 8971e17 Dec 6, 2019
@longfin longfin requested review from dahlia and limebell Dec 6, 2019
@longfin longfin requested a review from earlbread Dec 6, 2019
@dahlia
dahlia approved these changes Dec 6, 2019
@longfin longfin merged commit 1a0b598 into planetarium:master Dec 6, 2019
19 of 20 checks passed
19 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 43.13% of diff hit (target 85.92%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 85.8% (-0.13%) compared to 928225b
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191206.16 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.