Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where Swarm<T>.BootstrapAsync had reported invalid timeout #716

Merged
merged 3 commits into from Dec 26, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Dec 10, 2019

SwarmException is thrown when connecting to seed is failed, instead of TimeoutException.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Dec 10, 2019
@limebell limebell self-assigned this Dec 10, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #716 into master will decrease coverage by 0.04%.
The diff coverage is 8%.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   86.66%   86.61%   -0.05%     
==========================================
  Files         223      223              
  Lines       19102    19113      +11     
==========================================
  Hits        16555    16555              
- Misses       1369     1380      +11     
  Partials     1178     1178
Impacted Files Coverage Δ
Libplanet/Net/Protocols/KademliaProtocol.cs 64.67% <8%> (-1.05%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
@limebell limebell dismissed stale reviews from longfin, earlbread, and moreal via 9bc3832 Dec 11, 2019
@limebell limebell force-pushed the limebell:bugfix/bootstrap-exception branch from b76d515 to 9bc3832 Dec 11, 2019
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:bugfix/bootstrap-exception branch from 9bc3832 to 3a87183 Dec 19, 2019
@limebell

This comment has been minimized.

Copy link
Contributor Author

limebell commented Dec 26, 2019

/rebase

@libplanet libplanet force-pushed the limebell:bugfix/bootstrap-exception branch from 3a87183 to 9c64a25 Dec 26, 2019
@limebell limebell requested review from dahlia, longfin, moreal and earlbread Dec 26, 2019
@moreal
moreal approved these changes Dec 26, 2019
@limebell limebell merged commit 63b295f into planetarium:master Dec 26, 2019
19 of 20 checks passed
19 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 8% of diff hit (target 86.66%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 86.61% (-0.05%) compared to 62f07c0
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191226.1 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.