Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache for LookupStateReference #722

Merged
merged 2 commits into from Dec 27, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Dec 12, 2019

This adds the LRU cache for LookupStateReference.

@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Dec 12, 2019
@earlbread earlbread self-assigned this Dec 12, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #722 into master will increase coverage by 1.43%.
The diff coverage is 98.26%.

@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage    85.1%   86.53%   +1.43%     
==========================================
  Files         199      222      +23     
  Lines       18471    19209     +738     
==========================================
+ Hits        15720    16623     +903     
+ Misses       1577     1406     -171     
- Partials     1174     1180       +6
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 54.54% <100%> (-5.71%) ⬇️
Libplanet.Tests/Store/StoreTest.cs 98.36% <100%> (+0.12%) ⬆️
Libplanet/Store/DefaultStore.cs 86.54% <96.42%> (+1.01%) ⬆️
Libplanet/Store/StoreExtension.cs 0% <0%> (-71.43%) ⬇️
Libplanet.Tests/Store/StoreFixture.cs 97.27% <0%> (-2.73%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 64.27% <0%> (-0.4%) ⬇️
....Stun.Tests/Stun/Messages/ConnectionAttemptTest.cs 100% <0%> (ø)
...Stun/Messages/ConnectionBindSuccessResponseTest.cs 100% <0%> (ø)
... and 34 more
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:add-cache-for-lookup-stateref branch from 5b9292b to 70e0e7b Dec 26, 2019
@earlbread earlbread force-pushed the earlbread:add-cache-for-lookup-stateref branch from 70e0e7b to fd9b656 Dec 26, 2019
@earlbread earlbread requested a review from moreal Dec 26, 2019
Copy link
Member

longfin left a comment

It can be quite verbose...

Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
Libplanet/Store/DefaultStore.cs Outdated Show resolved Hide resolved
@earlbread earlbread dismissed stale reviews from limebell and dahlia via 3d0d7fe Dec 26, 2019
@earlbread earlbread requested review from longfin, dahlia and limebell Dec 26, 2019
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
@earlbread earlbread dismissed stale reviews from limebell and dahlia via 3879081 Dec 26, 2019
@earlbread earlbread force-pushed the earlbread:add-cache-for-lookup-stateref branch from 3d0d7fe to 3879081 Dec 26, 2019
@earlbread earlbread requested review from dahlia and limebell Dec 26, 2019
@moreal
moreal approved these changes Dec 26, 2019
@earlbread earlbread merged commit 813512d into planetarium:master Dec 27, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 98.26% of diff hit (target 85.1%)
Details
codecov/project 86.53% (+1.43%) compared to 8b6a48b
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191226.12 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:add-cache-for-lookup-stateref branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.