Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Swarm<T>'s Event internal [skip changelog] #725

Merged
merged 2 commits into from Dec 14, 2019

Conversation

@Oaroomy
Copy link
Contributor

Oaroomy commented Dec 14, 2019

Changed TxReceived, BlockReceived

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #725 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   86.67%   86.65%   -0.03%     
==========================================
  Files         221      221              
  Lines       18737    18737              
==========================================
- Hits        16241    16236       -5     
- Misses       1339     1344       +5     
  Partials     1157     1157
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 82.92% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KBucket.cs 90.99% <0%> (-2.71%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
@Oaroomy Oaroomy force-pushed the Oaroomy:remove-705 branch from 65eb4fe to d0b7d59 Dec 14, 2019
Copy link
Member

longfin left a comment

LGTM!

@limebell limebell merged commit 8c96330 into planetarium:master Dec 14, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.67%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +13.32% compared to 86fe5ed
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191214.13 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.