Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 604 #726

Merged
merged 3 commits into from Dec 14, 2019
Merged

Fix 604 #726

merged 3 commits into from Dec 14, 2019

Conversation

@Oaroomy
Copy link
Contributor

Oaroomy commented Dec 14, 2019

Changed KademliaProtocol.BootstrapAsync exception type from SwarmException to PeerDiscoveryException.

This pr fixes #604

@Oaroomy Oaroomy force-pushed the Oaroomy:fix-604 branch from 9325078 to 039895b Dec 14, 2019
@Oaroomy Oaroomy force-pushed the Oaroomy:fix-604 branch from 039895b to a433e11 Dec 14, 2019
@moreal

This comment has been minimized.

Copy link
Contributor

moreal commented Dec 14, 2019

@Oaroomy Oaroomy force-pushed the Oaroomy:fix-604 branch from 3ffbda4 to ec85e57 Dec 14, 2019
@dahlia
dahlia approved these changes Dec 14, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #726 into master will increase coverage by 1.52%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   85.09%   86.62%   +1.52%     
==========================================
  Files         197      222      +25     
  Lines       18060    18753     +693     
==========================================
+ Hits        15368    16244     +876     
+ Misses       1541     1352     -189     
- Partials     1151     1157       +6
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 95.86% <100%> (ø) ⬆️
Libplanet/Net/Protocols/PeerDiscoveryException.cs 25% <25%> (ø)
Libplanet/Net/Protocols/KademliaProtocol.cs 65.26% <50%> (-0.53%) ⬇️
....Stun.Tests/Stun/Messages/ConnectionAttemptTest.cs 100% <0%> (ø)
...Stun/Messages/ConnectionBindSuccessResponseTest.cs 100% <0%> (ø)
...Tests/Stun/Messages/AllocateSuccessResponseTest.cs 100% <0%> (ø)
...un.Tests/Stun/Messages/RefreshErrorResponseTest.cs 100% <0%> (ø)
...Stun.Tests/Stun/Attributes/MessageIntegrityTest.cs 100% <0%> (ø)
...et.Stun.Tests/Stun/Messages/AllocateRequestTest.cs 100% <0%> (ø)
... and 34 more
@limebell limebell merged commit f7cb3ee into planetarium:master Dec 14, 2019
19 of 20 checks passed
19 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 37.5% of diff hit (target 85.09%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 86.62% (+1.52%) compared to 8bed290
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191214.20 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.