Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable NetMQRuntime count #727

Merged
merged 2 commits into from Dec 14, 2019

Conversation

@wwhurin
Copy link
Contributor

wwhurin commented Dec 14, 2019

Title says it all.

@dahlia

This comment has been minimized.

Copy link
Member

dahlia commented Dec 14, 2019

/rebase

@moreal moreal requested review from dahlia, longfin, moreal, earlbread and limebell Dec 14, 2019
@libplanet libplanet force-pushed the wwhurin:configurable-netmqruntime-count branch from 09ef81b to d2b1763 Dec 14, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #727 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   86.65%   86.67%   +0.01%     
==========================================
  Files         221      221              
  Lines       18737    18741       +4     
==========================================
+ Hits        16236    16243       +7     
+ Misses       1344     1341       -3     
  Partials     1157     1157
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 82.95% <100%> (+0.02%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 95.86% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KBucket.cs 93.69% <0%> (+2.7%) ⬆️
Copy link
Member

longfin left a comment

Looks good to me, thanks!

@wwhurin wwhurin dismissed stale reviews from longfin and earlbread via a275393 Dec 14, 2019
@wwhurin wwhurin force-pushed the wwhurin:configurable-netmqruntime-count branch from d2b1763 to a275393 Dec 14, 2019
@dahlia dahlia requested review from longfin and earlbread Dec 14, 2019
CHANGES.md Outdated Show resolved Hide resolved
Closes #613
@wwhurin wwhurin force-pushed the wwhurin:configurable-netmqruntime-count branch from a275393 to e08a220 Dec 14, 2019
@dahlia dahlia requested a review from limebell Dec 14, 2019
@limebell limebell merged commit 8bed290 into planetarium:master Dec 14, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.65%)
Details
codecov/project 86.67% (+0.01%) compared to 8c96330
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191214.17 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.