Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to fill blocks when received continuous blocks #732

Merged
merged 5 commits into from Dec 26, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Dec 17, 2019

No description provided.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Dec 17, 2019
@limebell limebell self-assigned this Dec 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #732 into master will decrease coverage by 0.03%.
The diff coverage is 90%.

@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   86.64%   86.61%   -0.04%     
==========================================
  Files         223      223              
  Lines       19113    19152      +39     
==========================================
+ Hits        16561    16588      +27     
- Misses       1372     1382      +10     
- Partials     1180     1182       +2
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 96.01% <100%> (-0.04%) ⬇️
Libplanet/Net/Swarm.cs 82.89% <55.55%> (-0.43%) ⬇️
Libplanet/Store/DefaultStore.cs 85.53% <0%> (-1.1%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 64.67% <0%> (+0.39%) ⬆️
Libplanet/Net/Protocols/KBucket.cs 94.95% <0%> (+2.52%) ⬆️
@limebell limebell force-pushed the limebell:feature/boost-block-relay branch from 38029bf to 31aebe8 Dec 17, 2019
@limebell limebell requested review from longfin and moreal Dec 17, 2019
@limebell limebell force-pushed the limebell:feature/boost-block-relay branch from 31aebe8 to f83ce03 Dec 19, 2019
@dahlia

This comment has been minimized.

Copy link
Member

dahlia commented Dec 23, 2019

/rebase

@libplanet libplanet dismissed stale reviews from longfin and moreal via 670ba29 Dec 23, 2019
@libplanet libplanet force-pushed the limebell:feature/boost-block-relay branch from 01610f1 to 670ba29 Dec 23, 2019
@dahlia

This comment has been minimized.

Copy link
Member

dahlia commented Dec 24, 2019

/rebase

@libplanet libplanet force-pushed the limebell:feature/boost-block-relay branch from 670ba29 to 109e180 Dec 24, 2019
@longfin longfin requested review from longfin and moreal Dec 24, 2019
@limebell

This comment has been minimized.

Copy link
Contributor Author

limebell commented Dec 26, 2019

/rebase

@libplanet libplanet force-pushed the limebell:feature/boost-block-relay branch from 109e180 to deda714 Dec 26, 2019
@limebell limebell force-pushed the limebell:feature/boost-block-relay branch from deda714 to cc64643 Dec 26, 2019
@limebell limebell requested a review from longfin Dec 26, 2019
@moreal
moreal approved these changes Dec 26, 2019
@limebell limebell merged commit 8b6a48b into planetarium:master Dec 26, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 90% of diff hit (target 86.64%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +3.35% compared to 63b295f
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191226.5 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.