Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block mining and tx signing consistent/deterministic regardless of locale #734

Merged
merged 2 commits into from Dec 18, 2019

Conversation

@dahlia
Copy link
Member

dahlia commented Dec 17, 2019

No description provided.

@dahlia dahlia added the bug label Dec 17, 2019
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Dec 17, 2019
@dahlia dahlia self-assigned this Dec 17, 2019
@dahlia dahlia force-pushed the dahlia:locale-independence branch from 661dff5 to d17f2a7 Dec 17, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #734 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   86.65%   86.68%   +0.02%     
==========================================
  Files         222      222              
  Lines       18815    18824       +9     
==========================================
+ Hits        16305    16318      +13     
+ Misses       1351     1349       -2     
+ Partials     1159     1157       -2
Impacted Files Coverage Δ
Libplanet/Blocks/Block.cs 90.68% <100%> (ø) ⬆️
Libplanet/Tx/Transaction.cs 94.48% <100%> (ø) ⬆️
Libplanet.Tests/Common/Action/DumbAction.cs 81.48% <100%> (+1.08%) ⬆️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 95.86% <0%> (+0.1%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 65.78% <0%> (+0.52%) ⬆️
Libplanet/Net/NetMQSocketExtension.cs 81.63% <0%> (+4.08%) ⬆️
@dahlia

This comment has been minimized.

Copy link
Member Author

dahlia commented Dec 17, 2019

/rebase

@libplanet libplanet force-pushed the dahlia:locale-independence branch from d17f2a7 to b6d56dd Dec 17, 2019
@dahlia dahlia merged commit 3cacbe8 into planetarium:master Dec 18, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.65%)
Details
codecov/project 86.68% (+0.02%) compared to 82aaba0
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191217.16 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.