Skip to content

Make block mining and tx signing consistent/deterministic regardless of locale #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Dec 17, 2019

No description provided.

@dahlia dahlia added the bug Something isn't working label Dec 17, 2019
@dahlia dahlia self-assigned this Dec 17, 2019
@dahlia dahlia force-pushed the locale-independence branch from 661dff5 to d17f2a7 Compare December 17, 2019 15:45
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #734 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   86.65%   86.68%   +0.02%     
==========================================
  Files         222      222              
  Lines       18815    18824       +9     
==========================================
+ Hits        16305    16318      +13     
+ Misses       1351     1349       -2     
+ Partials     1159     1157       -2
Impacted Files Coverage Δ
Libplanet/Blocks/Block.cs 90.68% <100%> (ø) ⬆️
Libplanet/Tx/Transaction.cs 94.48% <100%> (ø) ⬆️
Libplanet.Tests/Common/Action/DumbAction.cs 81.48% <100%> (+1.08%) ⬆️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 95.86% <0%> (+0.1%) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 65.78% <0%> (+0.52%) ⬆️
Libplanet/Net/NetMQSocketExtension.cs 81.63% <0%> (+4.08%) ⬆️

@dahlia
Copy link
Contributor Author

dahlia commented Dec 17, 2019

/rebase

@dahlia dahlia merged commit 3cacbe8 into planetarium:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants