Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate state if received state height is shorter than Tip #736

Merged
merged 1 commit into from Dec 18, 2019

Conversation

@earlbread
Copy link
Member

earlbread commented Dec 18, 2019

This fixes a bug where the states were empty between the tip of the peer to receive the states and the tip of the downloaded block.

@earlbread earlbread added the bug label Dec 18, 2019
@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Dec 18, 2019
@earlbread earlbread self-assigned this Dec 18, 2019
Libplanet.Tests/Net/SwarmTest.cs Show resolved Hide resolved
Libplanet/Net/Swarm.cs Outdated Show resolved Hide resolved
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #736 into master will increase coverage by 0.02%.
The diff coverage is 94.31%.

@@            Coverage Diff             @@
##           master     #736      +/-   ##
==========================================
+ Coverage   86.71%   86.73%   +0.02%     
==========================================
  Files         222      222              
  Lines       18824    18884      +60     
==========================================
+ Hits        16323    16379      +56     
- Misses       1345     1349       +4     
  Partials     1156     1156
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 95.96% <100%> (+0.1%) ⬆️
Libplanet/Net/Swarm.cs 83.13% <87.8%> (+0.06%) ⬆️
Libplanet/Net/Protocols/KBucket.cs 90.99% <0%> (-2.71%) ⬇️
CHANGES.md Outdated Show resolved Hide resolved
@earlbread earlbread force-pushed the earlbread:fix-receive-recent-state branch from da506c2 to 32d410d Dec 18, 2019
@earlbread earlbread requested review from dahlia and longfin Dec 18, 2019
@earlbread earlbread dismissed stale reviews from dahlia, longfin, and limebell via c9954e3 Dec 18, 2019
@earlbread earlbread force-pushed the earlbread:fix-receive-recent-state branch from 32d410d to c9954e3 Dec 18, 2019
@earlbread earlbread requested review from dahlia, limebell and longfin Dec 18, 2019
@dahlia
dahlia approved these changes Dec 18, 2019
@earlbread earlbread merged commit 59fd941 into planetarium:master Dec 18, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 94.31% of diff hit (target 86.71%)
Details
codecov/project 86.73% (+0.02%) compared to 3cacbe8
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191218.5 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:fix-receive-recent-state branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.