Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Swarm<T>.Peers property to public #739

Merged
merged 2 commits into from Dec 23, 2019

Conversation

@limebell
Copy link
Contributor

limebell commented Dec 19, 2019

User of libplanet may want to get information of peers in its routing table.

@limebell limebell requested review from dahlia, longfin, earlbread and moreal Dec 19, 2019
@limebell limebell self-assigned this Dec 19, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #739 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   86.71%   86.71%   +<.01%     
==========================================
  Files         222      222              
  Lines       18891    18891              
==========================================
+ Hits        16381    16382       +1     
+ Misses       1351     1350       -1     
  Partials     1159     1159
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 83.08% <100%> (-0.06%) ⬇️
Libplanet/Net/NetMQSocketExtension.cs 77.55% <0%> (-4.09%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 65.78% <0%> (+0.52%) ⬆️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 78.59% <0%> (+0.73%) ⬆️
CHANGES.md Outdated Show resolved Hide resolved
@limebell limebell force-pushed the limebell:refactor/introduce-peers branch from 08a7721 to 97d754e Dec 19, 2019
@limebell limebell requested a review from dahlia Dec 23, 2019
@moreal
moreal approved these changes Dec 23, 2019
@dahlia
dahlia approved these changes Dec 23, 2019
@longfin longfin merged commit 2fef308 into planetarium:master Dec 23, 2019
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 86.71%)
Details
codecov/project 86.71% (+<.01%) compared to c8708c9
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191219.10 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.