Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune Swarm<T> #744

Merged
merged 6 commits into from Dec 27, 2019
Merged

Tune Swarm<T> #744

merged 6 commits into from Dec 27, 2019

Conversation

@longfin
Copy link
Member

longfin commented Dec 27, 2019

This PR addresses some issues as below

  • Fixed a bug where Swarm<T>.StartAsync() had thrown NullReferenceException when without using NAT and host parameter.
  • To stabilize request processing, Swarm<T>._runtimeProcessor became a long-running task. (it's a dedicated thread.)
  • Swarm<T> became spawn more BindingProxies() to handle TURN request concurrently.
    • We should parameterize its count in the future.
@longfin longfin self-assigned this Dec 27, 2019
@longfin longfin force-pushed the longfin:bugfix/NAT-detection branch from 1cc15b3 to 27cd9ec Dec 27, 2019
@longfin longfin requested review from dahlia and earlbread Dec 27, 2019
@longfin longfin marked this pull request as ready for review Dec 27, 2019
{
}
});
catch (NetMQException)

This comment has been minimized.

Copy link
@earlbread

earlbread Dec 27, 2019

Member

How about adding logs when these exceptions occur?

This comment has been minimized.

Copy link
@longfin

longfin Dec 27, 2019

Author Member

I added logs at e337696.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 27, 2019

Codecov Report

Merging #744 into master will decrease coverage by 0.03%.
The diff coverage is 64.58%.

@@            Coverage Diff             @@
##           master     #744      +/-   ##
==========================================
- Coverage   86.54%   86.51%   -0.04%     
==========================================
  Files         222      222              
  Lines       19209    19232      +23     
==========================================
+ Hits        16624    16638      +14     
- Misses       1404     1414      +10     
+ Partials     1181     1180       -1
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 82.51% <64.58%> (-0.39%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️
Libplanet/Crypto/PrivateKey.cs 86.2% <0%> (+0.86%) ⬆️
Libplanet/Net/Protocols/KBucket.cs 94.95% <0%> (+2.52%) ⬆️
@longfin

This comment has been minimized.

Copy link
Member Author

longfin commented Dec 27, 2019

I added a commit(b63489e) to address an issue that a peer can't request TURN relay properly when it has IPv6 address.

@longfin longfin requested a review from earlbread Dec 27, 2019
CHANGES.md Outdated Show resolved Hide resolved
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
@longfin longfin requested a review from dahlia Dec 27, 2019
@dahlia
dahlia approved these changes Dec 27, 2019
@longfin longfin merged commit 0d8db5e into planetarium:master Dec 27, 2019
18 of 20 checks passed
18 of 20 checks passed
benchmarks (macos-latest) benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 64.58% of diff hit (target 86.54%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 86.51% (-0.04%) compared to 813512d
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20191227.6 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.