Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compress option to DefaultStore #753

Merged
merged 2 commits into from Jan 13, 2020
Merged

Conversation

@dahlia
Copy link
Member

dahlia commented Jan 8, 2020

This patch adds the compress option to DefaultStore() constructor, which is turned off by default, to reduce the size of stored data. This option does not compress blocks or transactions, but only block states. The effect is ~31%: 5.1 GB → 1.6 GB.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #753 into master will decrease coverage by 0.17%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   86.52%   86.34%   -0.18%     
==========================================
  Files         222      222              
  Lines       19261    19384     +123     
==========================================
+ Hits        16665    16738      +73     
- Misses       1413     1463      +50     
  Partials     1183     1183
Impacted Files Coverage Δ
Libplanet/Store/DefaultStore.cs 83.57% <25%> (-2.98%) ⬇️
Libplanet/Store/StoreExtension.cs 41.66% <47.16%> (+41.66%) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.32% <97.43%> (-0.05%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 96.1% <0%> (+0.09%) ⬆️
@dahlia dahlia force-pushed the dahlia:compression branch from 3077649 to 985480f Jan 10, 2020
@dahlia dahlia marked this pull request as ready for review Jan 11, 2020
@dahlia dahlia requested review from longfin, moreal, limebell and earlbread Jan 11, 2020
@dahlia dahlia self-assigned this Jan 11, 2020
@longfin longfin merged commit 6d93a64 into planetarium:master Jan 13, 2020
19 of 20 checks passed
19 of 20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
codecov/patch 56.25% of diff hit (target 86.52%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 86.34% (-0.18%) compared to 388f8a8
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200110.1 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.