Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CryptoBackend #758

Merged
merged 1 commit into from Jan 14, 2020
Merged

Add CryptoBackend #758

merged 1 commit into from Jan 14, 2020

Conversation

@earlbread
Copy link
Member

earlbread commented Jan 14, 2020

This PR adds CryptoConfig and ICryptoBackend to enable signing and verification library changes.

@earlbread earlbread requested review from dahlia, longfin, limebell and moreal Jan 14, 2020
@earlbread earlbread self-assigned this Jan 14, 2020
@claassistantio

This comment has been minimized.

Copy link

claassistantio commented Jan 14, 2020

CLA assistant check
All committers have signed the CLA.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #758 into master will decrease coverage by <.01%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   86.38%   86.37%   -0.01%     
==========================================
  Files         220      222       +2     
  Lines       19175    19196      +21     
==========================================
+ Hits        16564    16581      +17     
- Misses       1417     1421       +4     
  Partials     1194     1194
Impacted Files Coverage Δ
Libplanet/Crypto/DefaultCryptoBackend.cs 100% <100%> (ø)
Libplanet/Crypto/PublicKey.cs 90.9% <100%> (+0.9%) ⬆️
Libplanet/Crypto/CryptoConfig.cs 50% <50%> (ø)
Libplanet.Tests/Net/Protocols/TestTransport.cs 75.57% <0%> (-0.66%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 63.52% <0%> (-0.41%) ⬇️
Libplanet/Net/NetMQTransport.cs 77.12% <0%> (+0.14%) ⬆️
@earlbread earlbread force-pushed the earlbread:crypto-backend branch from 4126099 to 5c9c343 Jan 14, 2020
@earlbread earlbread force-pushed the earlbread:crypto-backend branch from 5c9c343 to b971190 Jan 14, 2020
@earlbread earlbread requested a review from longfin Jan 14, 2020
@earlbread earlbread force-pushed the earlbread:crypto-backend branch from b971190 to 0968c79 Jan 14, 2020
Libplanet/Crypto/ICryptoBackend.cs Outdated Show resolved Hide resolved
@earlbread earlbread dismissed stale reviews from limebell and longfin via 90c91f3 Jan 14, 2020
@earlbread earlbread force-pushed the earlbread:crypto-backend branch from 0968c79 to 90c91f3 Jan 14, 2020
@earlbread earlbread requested review from dahlia, longfin and limebell Jan 14, 2020
@dahlia
dahlia approved these changes Jan 14, 2020
@earlbread earlbread merged commit 25a97f5 into planetarium:master Jan 14, 2020
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 97.05% of diff hit (target 86.38%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +10.67% compared to 524209d
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200114.9 had test failures
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
@earlbread earlbread deleted the earlbread:crypto-backend branch Jan 14, 2020
@moreal
moreal approved these changes Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.