Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CryptoBackend #758

Merged
merged 1 commit into from Jan 14, 2020
Merged

Add CryptoBackend #758

merged 1 commit into from Jan 14, 2020

Conversation

earlbread
Copy link
Contributor

This PR adds CryptoConfig and ICryptoBackend to enable signing and verification library changes.

@earlbread earlbread self-assigned this Jan 14, 2020
@claassistantio
Copy link

claassistantio commented Jan 14, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #758 into master will decrease coverage by <.01%.
The diff coverage is 97.05%.

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   86.38%   86.37%   -0.01%     
==========================================
  Files         220      222       +2     
  Lines       19175    19196      +21     
==========================================
+ Hits        16564    16581      +17     
- Misses       1417     1421       +4     
  Partials     1194     1194
Impacted Files Coverage Δ
Libplanet/Crypto/DefaultCryptoBackend.cs 100% <100%> (ø)
Libplanet/Crypto/PublicKey.cs 90.9% <100%> (+0.9%) ⬆️
Libplanet/Crypto/CryptoConfig.cs 50% <50%> (ø)
Libplanet.Tests/Net/Protocols/TestTransport.cs 75.57% <0%> (-0.66%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 63.52% <0%> (-0.41%) ⬇️
Libplanet/Net/NetMQTransport.cs 77.12% <0%> (+0.14%) ⬆️

longfin
longfin previously approved these changes Jan 14, 2020
longfin
longfin previously approved these changes Jan 14, 2020
limebell
limebell previously approved these changes Jan 14, 2020
Libplanet/Crypto/ICryptoBackend.cs Outdated Show resolved Hide resolved
@earlbread earlbread merged commit 25a97f5 into planetarium:master Jan 14, 2020
@earlbread earlbread deleted the crypto-backend branch January 14, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants