Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade C# to 8.0 with maintaining .NET Standard 2.0 #794

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@dahlia
Copy link
Member

dahlia commented Feb 12, 2020

Introduce C# 8.0 so that we use native async streams and null reference checks (#468). However, in this patch we just upgrade only Libplanet and Libplanet.Stun projects to use C# 8.0, without such new features. <Nullable>enable</Nullable> is not turned on yet, and AsyncEnumerator package is still there (see also the TODO comment in the Libplanet.csproj). Libplanet.Tests and Libplanet.Stun.Tests projects are still stuck with C# 7.1 as Unity is still so too. This patch is a smallest change to keep the build barely unbroken.

So this also require @planetarium/libplanet you folks to upgrade .NET Core SDK to 3.1+ and Mono (MDK) to 6.4+.

@dahlia dahlia added the suggestion label Feb 12, 2020
@dahlia dahlia requested review from longfin, limebell, earlbread and moreal Feb 12, 2020
@dahlia dahlia self-assigned this Feb 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #794 into master will increase coverage by 6.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   80.17%   86.58%   +6.41%     
==========================================
  Files          61      227     +166     
  Lines        1513    19674   +18161     
==========================================
+ Hits         1213    17035   +15822     
- Misses        271     1417    +1146     
- Partials       29     1222    +1193
Impacted Files Coverage Δ
Libplanet/Net/Messages/BlockHashes.cs 100% <0%> (ø)
Libplanet/Net/NoSwarmContextException.cs 0% <0%> (ø)
Libplanet.Tests/Action/ActionEvaluationTest.cs 96.66% <0%> (ø)
Libplanet.Tests/Store/StoreTest.cs 98.38% <0%> (ø)
Libplanet/Blocks/Block.cs 84.22% <0%> (ø)
Libplanet/Net/PreloadBlockDownloadFailEventArgs.cs 100% <0%> (ø)
Libplanet/Blocks/InvalidBlockTimestampException.cs 100% <0%> (ø)
Libplanet/Tx/InvalidTxUpdatedAddressesException.cs 84.61% <0%> (ø)
Libplanet/Net/Swarm.cs 86.17% <0%> (ø)
Libplanet.Tests/Net/SwarmTest.cs 96.44% <0%> (ø)
... and 157 more
[changelog skip]
@dahlia dahlia dismissed stale reviews from earlbread and moreal via e2dc1d1 Feb 12, 2020
@dahlia dahlia force-pushed the dahlia:csharp-8.0 branch from 17107b3 to e2dc1d1 Feb 12, 2020
@dahlia dahlia requested review from moreal and earlbread Feb 12, 2020
@moreal
moreal approved these changes Feb 13, 2020
@dahlia dahlia merged commit c25c078 into planetarium:master Feb 13, 2020
20 checks passed
20 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest)
Details
docs
Details
WIP Ready for review
Details
changelog Check was skipped.
Details
codecov/patch Coverage not affected when comparing c4572de...e2dc1d1
Details
codecov/project 86.58% (+6.41%) compared to c4572de
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200212.20 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.