Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #832

Merged
merged 1 commit into from Mar 24, 2020
Merged

Fix typo #832

merged 1 commit into from Mar 24, 2020

Conversation

@dahlia
Copy link
Member

dahlia commented Mar 24, 2020

This fixes #778, but the change in itself is not important. This purposes to trigger a master build on GitHub Actions.

Fix typo
Fix #778

[changelog skip]
@dahlia dahlia requested review from longfin, earlbread and moreal Mar 24, 2020
@dahlia dahlia self-assigned this Mar 24, 2020
@moreal
moreal approved these changes Mar 24, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #832 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
- Coverage   87.52%   87.47%   -0.05%     
==========================================
  Files         249      249              
  Lines       22500    22500              
==========================================
- Hits        19692    19681      -11     
- Misses       1462     1473      +11     
  Partials     1346     1346              
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 84.73% <100.00%> (-0.53%) ⬇️
Libplanet/Net/Protocols/KBucket.cs 85.59% <0.00%> (-2.55%) ⬇️
@dahlia dahlia merged commit f3d44d9 into planetarium:master Mar 24, 2020
20 of 21 checks passed
20 of 21 checks passed
benchmarks (macos-latest)
Details
dist
Details
benchmarks (ubuntu-18.04)
Details
benchmarks (windows-latest) benchmarks (windows-latest)
Details
docs
Details
bundle
Details
WIP Ready for review
Details
changelog Check was skipped.
Details
codecov/patch 100.00% of diff hit (target 87.52%)
Details
codecov/project 87.47% (+-0.05%) compared to a2dc2f1
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200324.5 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.