Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Trace.Assert() in Blockset and TransactionSet #833

Merged
merged 4 commits into from Mar 26, 2020

Conversation

@riemannulus
Copy link
Contributor

riemannulus commented Mar 24, 2020

Hi.

This PR should be resolve #806

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #833 into master will decrease coverage by 0.00%.
The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   87.49%   87.48%   -0.01%     
==========================================
  Files         249      249              
  Lines       22500    22507       +7     
==========================================
+ Hits        19686    19690       +4     
- Misses       1467     1471       +4     
+ Partials     1347     1346       -1     
Impacted Files Coverage Δ
Libplanet/Store/BlockSet.cs 82.05% <25.00%> (-6.84%) ⬇️
Libplanet/Store/TransactionSet.cs 81.39% <33.33%> (-3.23%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 96.55% <0.00%> (-0.10%) ⬇️
Libplanet/Net/NetMQTransport.cs 84.20% <0.00%> (+0.13%) ⬆️
Libplanet.Tests/Net/Protocols/TestTransport.cs 77.30% <0.00%> (+0.61%) ⬆️
Libplanet/Crypto/PrivateKey.cs 86.20% <0.00%> (+0.86%) ⬆️
@longfin longfin requested review from dahlia, moreal, longfin and earlbread Mar 25, 2020
@longfin longfin assigned longfin and riemannulus and unassigned longfin Mar 25, 2020
Copy link
Member

longfin left a comment

Thanks for your contribution! I left some comments for changes.

CHANGES.md Show resolved Hide resolved
Libplanet/Store/BlockSet.cs Outdated Show resolved Hide resolved
Libplanet/Store/TransactionSet.cs Outdated Show resolved Hide resolved
@longfin longfin self-requested a review Mar 26, 2020
@dahlia

This comment has been minimized.

Copy link
Member

dahlia commented Mar 26, 2020

/rebase

@github-actions github-actions bot force-pushed the riemannulus:remove-trace-assert-in-set branch from 89bf96f to 1982575 Mar 26, 2020
@dahlia
dahlia approved these changes Mar 26, 2020
Copy link
Member

dahlia left a comment

Due to our linear history policy, I rebased your commits on the latest master (instead of outdated one). Thanks for your contribution. We're going to merge this as soon as CI builds pass.

@dahlia dahlia requested a review from longfin Mar 26, 2020
@dahlia dahlia merged commit a9b931e into planetarium:master Mar 26, 2020
14 of 15 checks passed
14 of 15 checks passed
codecov/patch 30.00% of diff hit (target 87.49%)
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.48% (+-0.01%) compared to b6dc1ba
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20200326.6 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.