Add Swarm<T>.LastMessageTimestamp #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/relaunch-transport
branch
from
171a924
to
a17c724
Compare
longfin
force-pushed
the
feature/relaunch-transport
branch
from
a17c724
to
927cbde
Compare
longfin
requested review from
dahlia,
limebell,
earlbread,
moreal and
riemannulus
Codecov Report
@@ Coverage Diff @@
## main #964 +/- ##
===========================================
- Coverage 88.55% 13.81% -74.74%
===========================================
Files 315 291 -24
Lines 27652 26997 -655
===========================================
- Hits 24486 3729 -20757
- Misses 1620 23092 +21472
+ Partials 1546 176 -1370
|
earlbread
previously approved these changes
Aug 25, 2020
moreal
previously approved these changes
Aug 25, 2020
limebell
reviewed
Aug 25, 2020
longfin
force-pushed
the
feature/relaunch-transport
branch
from
927cbde
to
d25f3d8
Compare
moreal
previously approved these changes
Aug 25, 2020
earlbread
previously approved these changes
Aug 25, 2020
limebell
previously approved these changes
Aug 25, 2020
riemannulus
previously approved these changes
Aug 25, 2020
longfin
dismissed stale reviews from riemannulus, limebell, earlbread, and moreal
via
a0bf5dd
longfin
force-pushed
the
feature/relaunch-transport
branch
from
d25f3d8
to
a0bf5dd
Compare
limebell
previously approved these changes
Aug 25, 2020
moreal
previously approved these changes
Aug 25, 2020
dahlia
reviewed
Aug 25, 2020
|
Build seems to fail. 😥 |
longfin
force-pushed
the
feature/relaunch-transport
branch
from
f485112
to
fd67334
Compare
dahlia
previously approved these changes
Aug 25, 2020
Co-authored-by: Hong Minhee (洪 民憙) <hong.minhee@gmail.com>
longfin
force-pushed
the
feature/relaunch-transport
branch
from
fd67334
to
6a6b97c
Compare
|
I've found a mistake ( |
dahlia
approved these changes
Aug 25, 2020
limebell
approved these changes
Aug 25, 2020
moreal
approved these changes
Aug 25, 2020
riemannulus
approved these changes
Aug 25, 2020
earlbread
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
LastMessageTimestamptoSwarm<T>so that library users can take appropriate action. (e.g. restartingSwarm<T>)Also, I didn't mention deleted
Swarm<T>.LastReceivedbecause it hadn't been in the previous documentation.