Browse files

perf timechart: Use tid not pid for COMM change

commit 8f06d7e upstream.

A process that changes its comm field, does this on a per kernel
task struct basis. The timechart tool used, incorrectly, the pid
to track this, and should have used the tid instead...

Signed-off-by: Arjan van de Ven <>
Cc: Peter Zijlstra <>
Cc: Mike Galbraith <>
Cc: Paul Mackerras <>
Cc: Arnaldo Carvalho de Melo <>
Cc: Frederic Weisbecker <>
LKML-Reference: <>
Signed-off-by: Ingo Molnar <>
Signed-off-by: Greg Kroah-Hartman <>
  • Loading branch information...
fenrus75 authored and gregkh committed Jan 16, 2010
1 parent f2fa92b commit 5a20267b12fec85520acc1e839ee61f2ea16413d
Showing with 1 addition and 1 deletion.
  1. +1 −1 tools/perf/builtin-timechart.c
@@ -275,7 +275,7 @@ static u64 cpus_pstate_state[MAX_CPUS];
static int
process_comm_event(event_t *event)
- pid_set_comm(event->, event->comm.comm);
+ pid_set_comm(event->comm.tid, event->comm.comm);
return 0;
static int

0 comments on commit 5a20267

Please sign in to comment.