Skip to content

Conversation

@jreiberkyle
Copy link
Contributor

@jreiberkyle jreiberkyle commented Oct 14, 2022

  • Move release process from CONTRIBUTING.md to RELEASE.md because that doc is getting long
  • Add development branch guidelines
  • Require description of changes for PRs as well as IO examples when PRs change user interface
  • Change release process so that the version in main is the name of the next release + dev, a post-release step

Attribution: this is inspired by the openlayers release process.

Closes #691

@jreiberkyle jreiberkyle self-assigned this Oct 14, 2022
Comment on lines +7 to +21
#### Release Naming Conventions

The following are the release naming conventions:

1. Current dev version: Bumped version of last release with `dev` added to the end
* **PROPOSAL**: Version number is determined by [Semantic Versioning](https://semver.org/spec/v2.0.0.html)
1. Release version: Remove `dev` from current dev version

Example:
* If
* Previous Release Version == `1.0.0`
* Then
* Current Dev Version: `1.0.1dev`
* Release Version: `1.0.1`
* Next Dev Version: `1.0.2dev`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a new section


#### Step 1: Release on Github
*NOTE: This section refers to version names given in Release Naming Conventions section above.*
1. Create a release branch named `release-{Release Version}`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new

Comment on lines +41 to +42
1. Update `planet/__version__.py` to Next Dev Version
1. Merge PR for release branch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jreiberkyle seems good to me. This process is more careful about the state of the main branch than I usually am, and that's good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is inspired by the OpenLayers release process (and succinct overview by @tschaub). I was glad to have a template to work from.

@jreiberkyle jreiberkyle requested a review from sgillies October 14, 2022 20:08
@jreiberkyle
Copy link
Contributor Author

@sgillies your general thumbs up/down on changing the version in main to be {next release version}dev and general feel for the process would be great!

Co-authored-by: Tim Schaub <tschaub@users.noreply.github.com>
@jreiberkyle jreiberkyle merged commit 7f64368 into main Oct 17, 2022
@jreiberkyle jreiberkyle deleted the release-contributing-691 branch March 15, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update contributing docs release process and add guidance on naming branches

4 participants