New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max size for notes, similar to #35 #104

Open
noamtamim opened this Issue Feb 20, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@noamtamim

noamtamim commented Feb 20, 2018

skinparam maxMessageSize doesn't affect notes. I can see why that may be -- people may want more control over note formatting.
Please add another param, maxNoteSize that would do the same for notes.

And I see that in #35 you wonder if this name is good. I'd say wrapMessageWidth (if measured in pixels) and/or wrapMessageCols (if measured in characters) are better, since this param doesn't limit the size, it just inserts line breaks.

@Sidetalker

This comment has been minimized.

Sidetalker commented Feb 20, 2018

I knew this project wasn't dead, good, thanks.

@arnaudroques

This comment has been minimized.

Contributor

arnaudroques commented Feb 20, 2018

Not dead, but clearly overloaded :-)

Anyway, thanks for the suggested parameter name.
With last beta http://beta.plantuml.net/plantuml.jar you can now have:

@startuml
skinparam wrapWidth 100
component component1 [
   this is a very long component description
]
note left
   this is a very long note that show be wrapped
end note
@enduml

and also

@startuml
skinparam wrapMessageWidth 100
A->B:very long long long message name

@enduml

Note sure if we should have separate settings for notes, components...
So I let you guys talk about this (no time to think right now :-) )

@drboa

This comment has been minimized.

drboa commented Aug 7, 2018

Wrap width doesn't appear to be working on notes or on components...

@arnaudroques

This comment has been minimized.

@drboa

This comment has been minimized.

drboa commented Aug 28, 2018

I don't know if wrapWidth is meant to work on sequence diagrams (it would be extremely useful if it did...) but it doesn't do anything at the moment...

http://www.plantuml.com/plantuml/png/XOwn2i90343tV4KsfuABYqEfVeFGEVP2x-WrgRdKujzxAheA8JmUF9AkE9clSuOo9Ld8QCRDQEbJy8Y7FS0ffu6RzgpN8qREMQ5YqxHl_rKWweoMnkXmYQbW7S8xs-FFoYeZlcA0_dSsA1VPEMvg4wfWuTlACZ26HAFHN80bVAgkKlt-2G00

@arnaudroques

This comment has been minimized.

Contributor

arnaudroques commented Aug 28, 2018

Thanks for the feedback.
It should be fixed in last beta http://beta.plantuml.net/plantuml.jar

@arnaudroques

This comment has been minimized.

Contributor

arnaudroques commented Aug 30, 2018

Yes, but maybe we should use a separate setting for legend: general wrapWidth (for message, notes...) should be different that wrapWidth for legend that can be as wide as the diagram itself.
Any though ?

@zimchaa

This comment has been minimized.

zimchaa commented Sep 24, 2018

I'm not sure if it should, but wrapWidth doesn't seem to be working in Activity (Beta) for notes:

@startuml
skinparam wrapWidth 150

title: Note wrapWidth Test

start 
    :This is a very long process step;
    note: This is a very very long note
stop

@enduml

PlantUML Link

@arnaudroques

This comment has been minimized.

Contributor

arnaudroques commented Sep 25, 2018

I'm not sure if it should, but wrapWidth doesn't seem to be working in Activity (Beta) for notes:

Thanks for the report. This is fixed in last beta http://beta.plantuml.net/plantuml.jar

@zimchaa

This comment has been minimized.

zimchaa commented Sep 26, 2018

Thanks for the report. This is fixed in last beta http://beta.plantuml.net/plantuml.jar

This is amazing - not sure you're watching this but I've downloaded the beta and confirmed it sorted on Windows (7) (doesn't use GraphViz but: latest verstion).

Note wrapWidth Test.txt
note wrapwidth test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment