New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svglinktarget param set by FileFormatOption is overridden #144

Open
hicyo opened this Issue Sep 19, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hicyo

hicyo commented Sep 19, 2018

Hi,
It seems that the svglinktarget set with FileFormatOption class is not taken into account when generating svg files.

new FileFormatOption(FileFormat.SVG).withSvgLinkTarget("_blank")

I located where this custom value is overridden by another one which can be the default value "_top" or the one got from skinparam.

Class: UmlDiagram
Method: exportDiagramNow

fileFormatOption = fileFormatOption.withSvgLinkTarget(getSkinParam().getSvgLinkTarget());

I expect to apply the one provided by FileFormatOption if there is no skinparam defined.

Thank you

@arnaudroques

This comment has been minimized.

Show comment
Hide comment
@arnaudroques

arnaudroques Sep 19, 2018

Contributor

Many thanks for the detailled report.
This is fixed in last beta http://beta.plantuml.net/plantuml.jar and will be integrated in next official release.

Contributor

arnaudroques commented Sep 19, 2018

Many thanks for the detailled report.
This is fixed in last beta http://beta.plantuml.net/plantuml.jar and will be integrated in next official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment