Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gantt] thursday are colored in #AAF #432

Closed
liuzhaowei55 opened this issue Dec 31, 2020 · 8 comments
Closed

[gantt] thursday are colored in #AAF #432

liuzhaowei55 opened this issue Dec 31, 2020 · 8 comments

Comments

@liuzhaowei55
Copy link

How to do this?

@Nordes
Copy link

Nordes commented Jan 8, 2021

As of now, in the code we can see that we can only mark the day "as closed".

image

File: src/net/sourceforge/plantuml/project/lang/SubjectDayOfWeek.java

In order to specify color like 2021-01-04 to 2021-01-10 are colored in #d2d2d2, the author (or someone) would have to add the "NLP" part. My guess is that it would be not "so" complicated.

@Nordes
Copy link

Nordes commented Jan 8, 2021

I've done a PR, so maybe it will be merged soon so you can use the feature ;)

image

@Nordes
Copy link

Nordes commented Jan 8, 2021

@liuzhaowei55 this will normally be part of the next version of plantuml (merge request was completed)

@arnaudroques
Copy link
Contributor

It's available online, and on the last beta http://beta.plantuml.net/plantuml.jar

Thanks to @Nordes for the code !

@Nordes
Copy link

Nordes commented Jan 8, 2021

You're welcome

@liuzhaowei55
Copy link
Author

@Nordes @arnaudroques Thank you so much for solving this problem so quickly and getting online. I use plantuml in my DoukuWiki.

@ctr
Copy link

ctr commented Jan 17, 2021

@The-Lum
Copy link
Collaborator

The-Lum commented Jan 20, 2023

Hi all,

[This is an Issue Review]
This is now fixed.


And FYI @ctr:

it isn't working in monthly view for me

This is now fixed:

Regards.

@The-Lum The-Lum closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants