New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt runtime exception #62

Open
trothwell opened this Issue Jun 25, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@trothwell

trothwell commented Jun 25, 2017

http://www.plantuml.com/plantuml/png/AqxCAU6gvghMud9Kg55mud86abfSjLor0000

Actual exception (will work once issue is fixed)
error

@startuml
salt
{
{*
A | B
C | *
}
}
@enduml
@danwos

This comment has been minimized.

Show comment
Hide comment
@danwos

danwos Dec 19, 2017

Any updates on this?
I'm not able to to get any salt interface running with the latest plantuml version (1.2017.20)

danwos commented Dec 19, 2017

Any updates on this?
I'm not able to to get any salt interface running with the latest plantuml version (1.2017.20)

@arnaudroques

This comment has been minimized.

Show comment
Hide comment
@arnaudroques

arnaudroques Dec 19, 2017

Contributor

Ok, we'll look into this.
But there is a syntax error in your diagram. I am not sure about you are trying to do.
Are you trying to draw a table or a menu ?

The following example are working fine:

http://www.plantuml.com/plantuml/uml/SoWkIImgAStDuIfEp2dXgkQgLkPoLAXHSE9o1f9QNBL0w92Qbm9K0G00

@startuml
salt
{
{#
A | B
C | *
}
}
@enduml

http://www.plantuml.com/plantuml/uml/SoWkIImgAStDuIfEp2dXgkQgrb9mLAXHS5AevNBcgWL2XzIy5A0y0000

@startuml
salt
{
{* A | B }
C
}
}
@enduml
Contributor

arnaudroques commented Dec 19, 2017

Ok, we'll look into this.
But there is a syntax error in your diagram. I am not sure about you are trying to do.
Are you trying to draw a table or a menu ?

The following example are working fine:

http://www.plantuml.com/plantuml/uml/SoWkIImgAStDuIfEp2dXgkQgLkPoLAXHSE9o1f9QNBL0w92Qbm9K0G00

@startuml
salt
{
{#
A | B
C | *
}
}
@enduml

http://www.plantuml.com/plantuml/uml/SoWkIImgAStDuIfEp2dXgkQgrb9mLAXHS5AevNBcgWL2XzIy5A0y0000

@startuml
salt
{
{* A | B }
C
}
}
@enduml
@danwos

This comment has been minimized.

Show comment
Hide comment
@danwos

danwos Dec 19, 2017

Thanks for the fast response.
After a small research of my error, it may not be related to the one of the issue reporter.

Error reason: If "salt" starts with leading whitespaces, an error gets thrown:

@startuml
   salt
{
  Just plain text
}
@enduml

If using "@startsalt", it's working and the content itself can have leading whitespaces.

Why this may be important?
I'm using plantuml inside sphinx.
And normally a plantuml code integration looks like this:

.. uml::

    @startuml
        node test
        node test2
        test -> test2
    @enduml

Trying to use "salt", this kind of text structuring is not possible.
This does not work, as "salt" has leading whitespaces:

... uml::
    
    @startuml
        salt
        {
            Just plain text
        }
    @enduml

Currently it must look like this:

... uml::
    
@startuml
salt
   {
      Just plain text
   }
@enduml

or you use @startsalt instead:

... uml::
    
    @startsalt
    {
        Just plain text
    }
    @endsalt

Preferred change: As the error message is not really telling what went wrong, leading whitespaces in front of "salt" should be automatically removed. (This seems to be already done for each other plantuml command).

danwos commented Dec 19, 2017

Thanks for the fast response.
After a small research of my error, it may not be related to the one of the issue reporter.

Error reason: If "salt" starts with leading whitespaces, an error gets thrown:

@startuml
   salt
{
  Just plain text
}
@enduml

If using "@startsalt", it's working and the content itself can have leading whitespaces.

Why this may be important?
I'm using plantuml inside sphinx.
And normally a plantuml code integration looks like this:

.. uml::

    @startuml
        node test
        node test2
        test -> test2
    @enduml

Trying to use "salt", this kind of text structuring is not possible.
This does not work, as "salt" has leading whitespaces:

... uml::
    
    @startuml
        salt
        {
            Just plain text
        }
    @enduml

Currently it must look like this:

... uml::
    
@startuml
salt
   {
      Just plain text
   }
@enduml

or you use @startsalt instead:

... uml::
    
    @startsalt
    {
        Just plain text
    }
    @endsalt

Preferred change: As the error message is not really telling what went wrong, leading whitespaces in front of "salt" should be automatically removed. (This seems to be already done for each other plantuml command).

@arnaudroques

This comment has been minimized.

Show comment
Hide comment
@arnaudroques

arnaudroques Dec 19, 2017

Contributor

Thanks for the detailed report.
Last beta http://beta.plantuml.net/plantuml.jar ignores leading whitespaces in front of "salt".
Tell us if it's not working for you!

Contributor

arnaudroques commented Dec 19, 2017

Thanks for the detailed report.
Last beta http://beta.plantuml.net/plantuml.jar ignores leading whitespaces in front of "salt".
Tell us if it's not working for you!

@danwos

This comment has been minimized.

Show comment
Hide comment
@danwos

danwos Dec 19, 2017

Works! Thanks for fixing this.

danwos commented Dec 19, 2017

Works! Thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment