-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Swift support for Protocol and Struct in class diagram #1028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swift support for Protocol and Struct in class diagram #1028
Conversation
|
Hello all,
FYI: I just add |
To follow this new PlantUML functionality: - plantuml/plantuml#1028 Adding on `line begin keywords`: - `protocol` - `struct`
…ords (`remove`, `compact`, ...) (#491) * upd: add keywords on `hide & show` Add on `hide & show` section: - `remove` - `empty description` - `@unlinked` - `$tag` * upd: add keywords (on `line begin keywords`) Add on `line begin keywords`: - `json` - `compact` [TODO: `mode compact`] * upd: add `protocol` and `struct` on `keywords` To follow this new PlantUML functionality: - plantuml/plantuml#1028 Adding on `line begin keywords`: - `protocol` - `struct`
| gender = EntityGenderUtils.byEntityType(LeafType.ABSTRACT_CLASS); | ||
| } else if (arg1.equalsIgnoreCase("annotation")) { | ||
| gender = EntityGenderUtils.byEntityType(LeafType.ANNOTATION); | ||
| } else if (arg1.equalsIgnoreCase("protocol")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @bobjacobsen, and all,
Why the executeDescriptionDiagram function (see line 134):
does not have the same lines:
} else if (arg1.equalsIgnoreCase("protocol")) {
gender = EntityGenderUtils.byEntityType(LeafType.PROTOCOL);
} else if (arg1.equalsIgnoreCase("struct")) {
gender = EntityGenderUtils.byEntityType(LeafType.STRUCT);|
My apologies. I didn't realize that code was there. Should I create another PR with that added? |
Add new types: - protocol - struct - exception _Ref.:_ - plantuml/plantuml#1028 - plantuml/plantuml#1056
|
@startuml class Specialite { class Filiere { class Matiere { class Admin { class Presence { Etudiant --> Filiere |
This extends the class diagram support to include Protocol and Struct types with circle-P and circle-S letters respectively. This allows use of the diagrams for the Swift language.
This PR doesn't include updates for the web pages (see the "Declaring element" section, as couldn't find where that was maintained. All that's needed is to add "protocol" and "struct" examples to that section.