Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsconfig-paths to repo without build errors #300

Closed
karlfloersch opened this issue Jun 24, 2019 · 1 comment
Closed

Add tsconfig-paths to repo without build errors #300

karlfloersch opened this issue Jun 24, 2019 · 1 comment
Labels
bug Something isn't working cleanup Just cleaning things up @pigi Tasks for @pigi

Comments

@karlfloersch
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It would be great if we could use tsconfig paths, using the compiler option so that we can reference paths in our repo with something like src/types instead of ../../../src/types. However, when I added this (eg. here https://github.com/karlfloersch/pigi/tree/29704bb7dd9ca7cff44d623cd8f2db4edd2781fe ), there were build errors when contracts tried to compile core.

The paths failing during building is a known issue it seems. Some resources I found were:

While this is annoying & sad because I like the paths, don't want to waste any more time trying to figure it out.

Describe the solution you'd like
If anyone knows how to set this up it would be lovely! Otherwise we will stick to our ugly ../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../../ syntax 😄

@karlfloersch karlfloersch added @pigi Tasks for @pigi cleanup Just cleaning things up bug Something isn't working labels Jun 24, 2019
@karlfloersch
Copy link
Contributor Author

Turns out we cannot do this because it conflicts with build dependencies when importing another Lerna package. For instance, contracts trying to use core broke these imports.

For now, we can just use ../../

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cleanup Just cleaning things up @pigi Tasks for @pigi
Projects
None yet
Development

No branches or pull requests

1 participant