Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/437/persist pending block #441

Merged

Conversation

@willmeister
Copy link
Collaborator

commented Sep 12, 2019

Description

  • Changes the API of the aggregator to sign transaction receipts
  • Adds block info to transaction receipts
  • Adds persistent block storage

Based off of #439

Questions

  • Do the RollupBlock and TransactionReceipt look about right?

Metadata

Fixes

Contributing Agreement

willmeister added 11 commits Sep 9, 2019
…ate machine during async read-modify-write flows
… Also added conecpt of a RollupBlock
- Solidifying rollup block and transition concepts
- Stubbing out block submission
- Guaranteeing transitions are in order with locks

Merge branch 'master' into feat/437/PersistPendingBlock
…ex, and start/end root hash
@willmeister willmeister referenced this pull request Sep 12, 2019
1 of 1 task complete
Copy link
Contributor

left a comment

This is dope!!! 😃 The block and receipt types both look good to me.

One note is that it seems like some of the "meta" properties for the aggregator (mainly, block and transition number) are being stored in the MockRollupAggregator object, so they would presumably not be persisted on a system restart, right? If so, we will need to make sure those persist too or at least can be recovered from the DB somehow. Curious to hear your thoughts on handling this--I'm gonna approve for now though as that is probably beyond the ticket's scope anyways.

Another minor thought I had while reading over is that we may want to be careful with calling these types things like State and StateUpdate in terms of future naming collisions. However, I think there will probably be some more naming to make consistent (preStateRoot vs startRoot, etc.) when we get Karl's contracts so fine for now.

@willmeister

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 13, 2019

Good call on persisting transition number and block number! I'll add that, although I'm doing some rework of this file in another PR, so I may just merge this and do it there in order to avoid collisions.

@willmeister willmeister merged commit bf17cf4 into plasma-group:master Sep 13, 2019
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@willmeister willmeister deleted the willmeister:feat/437/PersistPendingBlock branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.