New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causal profile viewer fails on small profiles #25

Closed
jonhoo opened this Issue Oct 6, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@jonhoo
Contributor

jonhoo commented Oct 6, 2015

Going to http://plasma-umass.github.io/coz/ and trying to upload the profileshown below, gives the following JavaScript error in the console (both Firefox and Chromium). Nothing happens in the UI after pressing "Open".

Uncaught TypeError: Cannot read property 'tagName' of null
  d @ d3-tip.min.js:1
  t @ d3-tip.min.js:1
  _a.call @ d3.min.js:3
  Profile.drawPlots @ profile.js:339
  update @ ui.js:18
  open_button.classed.on.reader.onload  @   ui.js:66
$ cat profile.coz
startup time=1444175051035166083
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:200  speedup=0.00    duration=500061137  selected-samples=33
progress-point  name=kmeans-pthread.c:206   type=source delta=1603740
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:154  speedup=0.50    duration=442057369  selected-samples=254
progress-point  name=kmeans-pthread.c:206   type=source delta=1428191
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:154  speedup=0.95    duration=406957290  selected-samples=245
progress-point  name=kmeans-pthread.c:206   type=source delta=1482547
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:193  speedup=1.00    duration=463013850  selected-samples=68
progress-point  name=kmeans-pthread.c:206   type=source delta=1480336
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:193  speedup=1.00    duration=461058169  selected-samples=67
progress-point  name=kmeans-pthread.c:206   type=source delta=1491955
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:186  speedup=0.65    duration=483157015  selected-samples=45
progress-point  name=kmeans-pthread.c:206   type=source delta=1573409
experiment  selected=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:154  speedup=0.50    duration=481681505  selected-samples=99
progress-point  name=kmeans-pthread.c:206   type=source delta=500000
shutdown    time=1444175054308446044    samples=9616
runtime time=3591296609
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:154  count=1789
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:156  count=3932
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:168  count=64
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:170  count=318
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:186  count=235
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:188  count=13
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:190  count=265
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:192  count=1277
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:193  count=449
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:200  count=217
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:202  count=3
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:203  count=1
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:206  count=38
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:230  count=486
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:232  count=405
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:234  count=106
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:235  count=1
samples location=/home/jon/dev/pkgs/coz-git/src/coz-git/benchmarks/kmeans/kmeans-pthread.c:244  count=1
@ccurtsinger

This comment has been minimized.

Member

ccurtsinger commented Oct 7, 2015

The plotting code does not gracefully handle profiles that do not have any lines of code with enough different virtual speedups to meet the threshold on the left. This needs to be fixed soon, but you can get a usable profile by re-running coz a few times on kmeans to collect more samples. It just appends to the profile in the current directory.

@ccurtsinger ccurtsinger changed the title from Cannot plot benchmark profile using online coz plotter to Causal profile viewer fails on small profiles Oct 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment