Use more generalized keyword argument for gyroradius #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces T_i paramter keyword with T for more generalization. Adds a deprectaion warning for notifying users.
github-actions
bot
added
the
plasmapy.formulary
|
Could someone please give this PR a review. |
Codecov Report
@@ Coverage Diff @@
## main #1210 +/- ##
=======================================
Coverage ? 96.98%
=======================================
Files ? 71
Lines ? 7030
Branches ? 0
=======================================
Hits ? 6818
Misses ? 212
Partials ? 0 Continue to review full report at Codecov.
|
namurphy
approved these changes
Jul 25, 2021
There was a problem hiding this comment.
Looks good to me! With a few slight edits it'll be ready to merge.
We use pre-commit to check that the code is formatted as expected by black and isort. We just added an option to implement these formatting fixes by including the following in a GitHub comment:
pre-commit.ci autofix
|
pre-commit.ci autofix |
namurphy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1170
Waiting for feedback on initial changes. Will proceed further with tests.
docstrings.