New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folding bug if folding disabled option is 0 #92

Merged
merged 2 commits into from Jun 17, 2014

Conversation

Projects
None yet
2 participants
@y0t4
Contributor

y0t4 commented Jun 16, 2014

Hi.

Fix a bug that setting of folding are not reflected.
I set g:vim_markdown_folding_disabled = 0 in vimrc, but markdown file is still folded because using exists().
So I use get() instead of exist()

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Jun 17, 2014

Nice catch. I think you meant "is still NOT folded".

Please also modify https://github.com/plasticboy/vim-markdown/blob/master/ftplugin/mkd.vim#L371 to use the same get(:g style as here.

You just taught me that g: is a dict =) !

@y0t4

This comment has been minimized.

Contributor

y0t4 commented Jun 17, 2014

Nice catch. I think you meant "is still NOT folded".

Oops.
Thank you for pointing out my mistake.

Please also modify https://github.com/plasticboy/vim-markdown/blob/master/ftplugin/mkd.vim#L371 to use the same get(:g style as here.

OK.
I'll edit two line (L371-372), and commit to this branch.
https://github.com/plasticboy/vim-markdown/blob/master/ftplugin/mkd.vim#L371-372

cirosantilli added a commit that referenced this pull request Jun 17, 2014

Merge pull request #92 from y0t4/fix_if_folding_disabled_is_0
Fix folding bug if folding disabled option is 0

@cirosantilli cirosantilli merged commit 17be3cd into plasticboy:master Jun 17, 2014

@cirosantilli

This comment has been minimized.

Collaborator

cirosantilli commented Jun 17, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment