Skip to content
This repository

Jul 10, 2014

  1. Carlos Antonio da Silva

    Get rid of extra module for group helpers

    Just use the existing ClassMethods module which is properly extended
    with AS::Concern.
  2. Carlos Antonio da Silva

    Use a different mapping name for testing the omniauth callback failure

    This leaks into Devise mappings overriding the existing :admin one, so
    depending on the test seed it fails like this:
    
        $ TESTOPTS="--seed=9972" rake
    
        ==> Devise.orm = :active_record
        Run options: --seed=9972
    
        ...
    
          1) Failure:
          MappingTest#test_allows_path_to_be_given [./test/mapping_test.rb:31]:
          Expected: "admin_area"
            Actual: "admin"
    
    Using a different name should avoid any test randomization issues.
  3. Carlos Antonio da Silva

    Fix test that checks for proper configuration of omniauth callback

    Previously the test was raising an ArgumentError by mistake:
    
        ArgumentError: wrong number of arguments (0 for 1)
            actionpack (4.1.4) lib/action_dispatch/routing/route_set.rb:328:in `eval_block'`
    
    The #eval_block method expects a proc/lambda argument that can be
    instance_exec'ed, not a real block. In the Rails implementation the block
    is passed to #draw, which calls #eval_block internally passing the block
    along, but as a Proc argument and not as a block.
    
    Also the error we were raising from #devise_for was a RuntimeError,
    changed to the expected ArgumentError. Adding an assertion on top of the
    expected message should ensure we won't have this issue again.
    
    This was introduced in 29da146, related
    to #2802.
  4. Carlos Antonio da Silva

    Use Devise's swap mechanism in failure app test

    Also refactor tests to remove the custom failure app class only used
    once in favor of an inline class for the specific test, makes it easier
    to follow what's going on.
  5. Carlos Antonio da Silva

    Create an anonymous class to test the failure app

    No need to have a named class inside the test.

Jul 06, 2014

  1. Vasiliy Ermolovich

    add documentation about `skip: :all` option to `devise_for` method

    nashby authored

Jul 03, 2014

  1. Lucas Mazza

    Update Rails dependency across all lockfiles

    lucasmazza authored

Jun 26, 2014

  1. Lucas Mazza

    Update Rails version across all the Gemfiles

    lucasmazza authored

Jun 24, 2014

  1. Lucas Mazza

    Merge pull request #3082 from greysteil/update-travis

    Update Travis config to test on ruby 2.1.2 instead of 2.1.1
    lucasmazza authored
  2. Lucas Mazza

    Update the overall dependencies and test with mongoid 4.0.0 for now on.

    lucasmazza authored
  3. Lucas Mazza

    Update `_prefixes` override to work with Rails 4.2

    lucasmazza authored

Jun 21, 2014

  1. José Valim

    Merge pull request #3083 from jjb/patch-1

    changelog detail for expire_all_remember_me_on_sign_out
    josevalim authored

Jun 20, 2014

  1. John Bachir

    changelog detail for expire_all_remember_me_on_sign_out

    explain that it's the configurability and not the functionality which is new
    jjb authored
  2. Grey Baker

    Update Travis config to test on ruby 2.1.2 instead of 2.1.1

    greysteil authored

Jun 19, 2014

  1. José Valim

    Merge pull request #3079 from Yenwod/add-setup-detail

    Add migration setup detail to README
    josevalim authored
  2. Yenwod

    Add migration setup detail to README

    Yenwod authored
  3. José Valim

    Merge pull request #3077 from ShepBook/minor-readme-grammar

    Make minor changes to readme grammar.
    josevalim authored
  4. Make minor changes to readme grammar.

    Jared Koumentis authored

Jun 18, 2014

  1. Rafael Mendonça França

    Merge pull request #3074 from adamniedzielski/remove-cancan-from-readme

    Outdated reference to CanCan in README
    rafaelfranca authored
  2. Adam Niedzielski

    Update README.md

    Remove reference to CanCan - it is no longer maintained

Jun 16, 2014

  1. José Valim

    Merge pull request #3072 from roryokane/patch-1

    Fix grammar and capitalization errors in README
    josevalim authored
  2. Rory O’Kane

    Fix grammar and capitalization errors in README

    roryokane authored

Jun 06, 2014

  1. José Valim

    Merge pull request #3054 from cheerfulstoic/devise-neo4j

    Changes to support devise-neo4j
    josevalim authored
  2. José Valim

    Merge pull request #3060 from thomasdarde/patch-1

    Update README.md
    josevalim authored
  3. Thomas Darde

    Update README.md

    Add more description on the way I18n.locale has to be set in case of multi-locale app.
    thomasdarde authored
  4. Brian Underwood

    User Model.to_adapter directly as suggested by @josevalim

  5. José Valim

    Update activatable.rb

    josevalim authored
  6. José Valim

    Merge pull request #3042 from dropletzz/group_helpers

    Helper methods for groups of mappings
    josevalim authored

Jun 05, 2014

  1. Brian Underwood

    Use User and Admin orm_adapter adapter in tests to support other ORMs…

    … (neo4j, in this case)

May 29, 2014

  1. Lucas Mazza

    Merge pull request #3048 from shanab/master

    Update README.md
    lucasmazza authored
  2. Ahmed Mostafa

    Update README.md

    Fixed incorrect method definition.
    shanab authored
  3. Brian Underwood

    Change test to use acts_like? so that we can have DateTime fields

May 28, 2014

  1. Giovanni Caniato

    group methods defined in the current scope

    dropletzz authored
  2. Lucas Mazza

    Swap the failure app during the test case properly.

    lucasmazza authored

May 27, 2014

  1. Giovanni Caniato

    moved helpers definition from routes to controllers

    dropletzz authored
Something went wrong with that request. Please try again.