Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

find_first_by_auth_conditions used instead of find_for_authentication #1752

Closed
pivotalhalogen opened this Issue · 4 comments

4 participants

@pivotalhalogen

See here: https://github.com/plataformatec/devise/blob/master/lib/devise/models/authenticatable.rb#L181

Should this be using find_for_authentication instead? It seems that we're not getting the override ability because of this.

@rodrigoflores
Collaborator

Thanks for the pull request

@josevalim
Owner

Hey everyone, I had to revert the pull request because find_for_authentication should not be called without an authentication workflow, and this pull request changed that. The reason is because authentication receives specific parameters like the request parameters and those won't be available where this change your made.

@pivotalhalogen could you please tell us what you are trying to achieve? We could either provide a specific hook for you or document an existing one.

@pivotalhalogen
@francocatena

I am trying to do exactly the same as @pivotalhalogen, any new on this? Since the issue is close this is considered _impossible_ or there is another way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.