Update the devise-example app #2255

Closed
josevalim opened this Issue Feb 1, 2013 · 15 comments

Comments

Projects
None yet
6 participants
Contributor

jayshepherd commented Feb 5, 2013

Are you looking to rebuild the demo app from scratch based on Rails 3.2.11 and latest devise gem and generators?

Collaborator

rafaelfranca commented Feb 5, 2013

Yes

Contributor

jayshepherd commented Feb 5, 2013

OK, I'll be happy to start work on it.

Contributor

jayshepherd commented Feb 6, 2013

I created a new app based on Rails 3.2.11 and Devise 2.2.3 located at: https://github.com/jayshepherd/devise_example

My goal was to duplicate the functionality and tests of the current devise_example.

Let me know any thoughts/questions/flames.

EDIT: I just realized that I forgot the rake task and so I will add that back in shortly. -- done.

Now that Rails 4.0 is final are you considering updating the demo app for Rails 4.0?

Contributor

jayshepherd commented Jul 6, 2013

Yes, I will look into that.

Contributor

jayshepherd commented Jul 10, 2013

Anything special folks want in the 4.0 example app that isn't in the original example?

Owner

josevalim commented Jul 10, 2013

Nothing in particular. :) Thanks for taking care of this @jayshepherd !

Contributor

jayshepherd commented Jul 10, 2013

OK, I've got it mostly working from a raw Rails 4.0.0 project with the current HEAD of Devise (49aebde).

https://github.com/jayshepherd/devise_example

The only outstanding issue is related to strong parameters and updating the user account. I will need to take some time to dig for a workaround with the minimal installation. (Any tips are appreciated!)

@josevalim try to add an additional field to User module and make it works with strong parameters

Contributor

jayshepherd commented Jul 11, 2013

I just added a commit to address the strong parameter issue.

Anything else you want added? This is basically taking the original devise_example and duplicating it's functions within a fresh rails and devise installation. What do you want to do with the repo?

Owner

josevalim commented Jul 12, 2013

@jayshepherd I could either fork your repository in place of that one, push your commits on top of that one or change the links to the your repository (in case you are planning to "maintain" it). Whatever you pick. :) Thanks for your work!

Anything special folks want in the 4.0 example app that isn't in the original example?

This would be helpful #2507
I am able to help.
:)

Contributor

jayshepherd commented Jul 20, 2013

@josevalim I'm happy to maintain it if you like.

Owner

josevalim commented Jul 26, 2013

Hey @jayshepherd, that would be awesome. I am going to change all links to your repository, thank you!

josevalim closed this Jul 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment