Confirmation tweaks

[markturner]

Resolves issue #2544

[josevalim]

@markturner, this looks great, thank you! Could you please take a look at the build? This pull request is breaking it.

[markturner]

Oops, sorry! I've fixed that now, except for just 2 remaining tests where I'm not quite sure what's happening.

I'll take another look over the weekend unless you or someone else can figure it out.

[markturner]

Sorry, I wasn't able to figure it out and I'm not going to be able to put anymore time into it. It's probably obvious to someone else but my testing knowledge is pretty much all rspec! Would be great if someone with more of a handle on this than me could get these last two tests to pass.

[josevalim]

Thanks @markturner, don't worry. We will get around to it and merge your fixes in.

[CraigSnowden]

Looks like this has already been integrated?

[josevalim]

No, I don't think it has yet.

[ghost]

Is this still relevant?

[ulissesalmeida]

@markturner Cold you please rebase your branch? Thanks.

[tegon]

I'm closing this since it has been here for a long time and probably will be too hard to rebase it.
If you find that this can still be relevant, feel free to open a new pull request with a similar implementation.

Thank you!