Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5 alpha : devise-40258bf100c0/lib/devise/failure_app.rb:9:in `<class:FailureApp>': uninitialized constant ActionController::RackDelegation (NameError) #3736

Closed
chasik opened this issue Sep 3, 2015 · 31 comments

Comments

@chasik
Copy link

commented Sep 3, 2015

In ActionPack with Rails 5 no module ActionController::RackDelegation

@carlosantoniodasilva

This comment has been minimized.

Copy link
Collaborator

commented Sep 3, 2015

Thanks, however we don't support Rails 5 yet - once a beta or release candidate is released, we will gladly add official support to it.

Meanwhile please feel free to send any pull request that might help us get closer to having devise working with Rails master. Thanks!

@jachenry

This comment has been minimized.

Copy link

commented Sep 19, 2015

RackDelegation was removed as part of this commit. Removing the reference inside lib/devise/failure_app.rb worked around the issue for me.

@grex84

This comment has been minimized.

Copy link

commented Sep 26, 2015

I'm having the same problem and removing include ActionController::RackDelegation gives me another error. Was this all i needed to do jachenry?

@jachenry

This comment has been minimized.

Copy link

commented Sep 26, 2015

@grex84 That's all I had to to do for this particular issue. There was another issue I faced around routes and scopes but it was not related to this error.

@djsegal

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2015

@carlosantoniodasilva: for future reference, this is resolved by #3714

@afstanton

This comment has been minimized.

Copy link

commented Jan 6, 2016

Now that Rails 5 Beta 1 is out, will we see some movement toward supporting it?

@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 6, 2016

Devise master supports Rails 5.

@afstanton

This comment has been minimized.

Copy link

commented Jan 6, 2016

Having just generated a Rails 5 Beta 1 app and installed Devise from the master branch, I can safely say that no, Devise master does not support Rails 5.

@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 6, 2016

Our test suite passes on Rails 5: https://travis-ci.org/plataformatec/devise/jobs/100575093. So if you are running into issues, please do a proper report or send pull requests. :) Be movement you want to see happening.

@afstanton

This comment has been minimized.

Copy link

commented Jan 6, 2016

The error I'm seeing is the one reported here. No need to file an additional report.

Perhaps I've done something wrong, but I see what I see.

@wuatanabe

This comment has been minimized.

Copy link

commented Jan 6, 2016

Hello, devise master seems to work for me with rails 5.0.0.beta1 (installed on Ms Windows).

@afstanton

This comment has been minimized.

Copy link

commented Jan 6, 2016

I'm not sure what I was doing wrong, but I think you're right. My sincere apologies.

@ifokeev

This comment has been minimized.

Copy link

commented Jan 7, 2016

devise_token_auth doesn't work because of Devise 3.5.3 in dependencies (3.5.3 has include ActionController::RackDelegation in lib/devise/failure_app.rb).
Have no idea how to use it :(

@fuzzylizard

This comment has been minimized.

Copy link

commented Jan 14, 2016

Still seeing this error when using Devise 3.5.3, Rails 5.0.0beta1 and trying to start the server.

.rbenv/versions/2.3.0/lib/ruby/gems/2.3.0/gems/devise-3.5.3/lib/devise/failure_app.rb:9:in '<class:FailureApp>': uninitialized constant ActionController::RackDelegation (NameError)

This is a brand new application. The only thing I have done to it is to remove turbolinks.

@josevalim

This comment has been minimized.

Copy link
Member

commented Jan 14, 2016

You need to use Devise master for Rails 5.0.0 beta.

@fuzzylizard

This comment has been minimized.

Copy link

commented Jan 14, 2016

Thanks, I got it working. For others that are experiencing this issue. Pull Devise from github and not rubygems.org. Although the version number is the same, the underlying code is not. The rubygems.org gem still has the RackDelegation code in it.

@stephannv

This comment has been minimized.

Copy link

commented Jan 14, 2016

For others tha are using devise_token_auth gem.
I'm using:

gem 'omniauth', '>= 1.0.0'
gem 'devise', git: 'git@github.com:plataformatec/devise.git'
gem 'devise_token_auth', git: 'git://github.com/lynndylanhurley/devise_token_auth.git'

gem 'devise', git: 'git@github.com:plataformatec/devise.git' solves the problem.
omniauth is devise_token_auth dependency too.

@jeremyrajan

This comment has been minimized.

Copy link

commented Jan 23, 2016

@stephanngamedev . That works 👍

@andrewostroumov

This comment has been minimized.

Copy link

commented Jan 24, 2016

@stephanngamedev Thanks! ⭐️

@saurabhh

This comment has been minimized.

Copy link

commented Feb 2, 2016

Thanks!!

@MaximAbramchuck

This comment has been minimized.

Copy link

commented Feb 3, 2016

@stephanngamedev Thanks! 👍

@pavlo

This comment has been minimized.

Copy link

commented Feb 6, 2016

Thank you @stephanngamedev!

@kevinhofmaenner

This comment has been minimized.

Copy link

commented Feb 7, 2016

@stephanngamedev Thanks!

@nishimaki

This comment has been minimized.

Copy link

commented Feb 9, 2016

Thank you

@brunojppb

This comment has been minimized.

Copy link

commented Feb 9, 2016

@stephanngamedev Thanks a lot! 👍

cycorld pushed a commit to cycorld/minimalist that referenced this issue Feb 12, 2016
@sunyanl

This comment has been minimized.

Copy link

commented Feb 21, 2016

@stephanngamedev thanks :)

@websumy

This comment has been minimized.

Copy link

commented Feb 23, 2016

You also can specify devise version 4.0.0.rc1

gem 'devise', '4.0.0.rc1'

@udviklers

This comment has been minimized.

Copy link

commented Mar 9, 2016

@stephanngamedev Thanks a lot!

@bestori

This comment has been minimized.

Copy link

commented Mar 30, 2016

+1 here for

gem 'devise', git: 'git@github.com:plataformatec/devise.git'

@mohan

This comment has been minimized.

Copy link

commented Apr 3, 2016

gem 'devise', '4.0.0.rc2'

@AzDarGee

This comment has been minimized.

Copy link

commented Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.