New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ThreadError in Users/sessions#create uncaught throw `warden' in thread 0xe2ea4c8 #754
Comments
Here is the full trace D:/Ruby187/lib/ruby/gems/1.8/bundler/gems/devise-555435e6fefc/lib/devise/hooks/activatable.rb:8:in |
Could you please isolate the error in a small application and push it to Github? |
Hi, here is the repository |
I tried checking out a few revisions. It was introduced here: 379d8c6. |
Okay, the problem is that the :recall option is being passed. If I change the line as follows (not saying that it makes sense), it works again: throw :warden, options.merge(:message => record.inactive_message).slice(:scope, :message, :store, :event) Now I'm not sure about the details but it looks like this triggers the FailureApp (line 27) so the thrown warden doesn't ever get caught. Should this work like it is or should it not? A quick fix would be to go back to the old version or exclude the :recall option from the passed options. |
Don't pass options forward, this fixes uncaught warden error. Unfortunately could not write a test for it, although easily reproducible in Rails applications. Closed by 7ff0231 |
Can we reopen this issue? Is it caused by the :recall option? I enabled this because :recall option is useful for Issue 675(https://github.com/plataformatec/devise/issues/closed#issue/675) so that confirmable/activable can be used via ajax. |
I have thought more about the issue and I think the best way to achieve what described in this ticket would be by customizing the failure app. |
So, should the :recall option be forwarded? If the :recall option is not forwarded, it will fail ajaxied login with activable/confirmable. |
No. We should handle it in another way. |
Okay. Do you have any idea in mind now? I can help to integrate it. |
…nately could not write a test for it, although easily reproducible in Rails applications. Closes #754
Using the code at master of devise
gem 'devise', :git => 'git://github.com/plataformatec/devise.git'
with :confirmable in my modle
class User < ActiveRecord::Base
devise :database_authenticatable, :registerable,
:recoverable, :rememberable, :trackable, :validatable, :confirmable
end
When i signed in a new user without registration confirmation, i got these error messages:
ThreadError in Users/sessions#create
Showing F:/XXX/_header.html.erb where line #4 raised:
uncaught throw `warden' in thread 0xe2ea4c8
Extracted source (around line #4):
1:
2:
3:
4: <% if user_signed_in? %>
5:
The text was updated successfully, but these errors were encountered: