Adding back links partial to shared #1696

Merged
merged 3 commits into from Mar 3, 2012

Conversation

Projects
None yet
3 participants
@rodrigoflores
Contributor

rodrigoflores commented Mar 3, 2012

To be able to use links partial, on scoped views we moved it back to
shared folder. Should solve #1692

Rodrigo Flores added some commits Mar 3, 2012

+ include ViewPathTemplates
+ source_root File.expand_path("../../../../app/views/devise", __FILE__)
+ desc "Copies shared Devise views to your application."
+

This comment has been minimized.

@josevalim

josevalim Mar 3, 2012

Member

Please invoke hide! in this generator so we hide it as well from rails g

@josevalim

josevalim Mar 3, 2012

Member

Please invoke hide! in this generator so we hide it as well from rails g

This comment has been minimized.

@carlosantoniodasilva

carlosantoniodasilva Mar 3, 2012

Collaborator

I think hide! is not available for 3.2, is it? Wouldn't it break the generator in case it is not?

@carlosantoniodasilva

carlosantoniodasilva Mar 3, 2012

Collaborator

I think hide! is not available for 3.2, is it? Wouldn't it break the generator in case it is not?

@rodrigoflores

This comment has been minimized.

Show comment
Hide comment
@rodrigoflores

rodrigoflores Mar 3, 2012

Contributor

Ready to merge?

Contributor

rodrigoflores commented Mar 3, 2012

Ready to merge?

@carlosantoniodasilva

This comment has been minimized.

Show comment
Hide comment
@carlosantoniodasilva

carlosantoniodasilva Mar 3, 2012

Collaborator

Há, really! I forgot, pls ignore :P

At.
Carlos Antonio

On Saturday, March 3, 2012 at 11:35 AM, Rodrigo Flores wrote:

Ready to merge?


Reply to this email directly or view it on GitHub:
#1696 (comment)

Collaborator

carlosantoniodasilva commented Mar 3, 2012

Há, really! I forgot, pls ignore :P

At.
Carlos Antonio

On Saturday, March 3, 2012 at 11:35 AM, Rodrigo Flores wrote:

Ready to merge?


Reply to this email directly or view it on GitHub:
#1696 (comment)

rodrigoflores added a commit that referenced this pull request Mar 3, 2012

Merge pull request #1696 from plataformatec/reverting
Adding back links partial to shared

@rodrigoflores rodrigoflores merged commit bc09699 into master Mar 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment