Redirect to sign_in page when trying to access password#edit without a reset password token #1902

Merged
merged 2 commits into from Jun 8, 2012

Conversation

Projects
None yet
4 participants
Contributor

gbataille commented Jun 8, 2012

As discussed on the mailing list, would hopefully help to lessen some confusion around the password#edit action and how to use it.

josevalim added a commit that referenced this pull request Jun 8, 2012

Merge pull request #1902 from gbataille/master
Redirect to sign_in page when trying to access password#edit without a reset password token

@josevalim josevalim merged commit 5df7105 into plataformatec:master Jun 8, 2012

Collaborator

carlosantoniodasilva commented Jun 14, 2012

@gbataille nice, thanks :)

Contributor

gbataille commented Jun 14, 2012

glad it's usefull

On Thu, Jun 14, 2012 at 3:37 AM, Carlos Antonio da Silva <
reply@reply.github.com

wrote:

@gbataille nice, thanks :)


Reply to this email directly or view it on GitHub:
#1902 (comment)

exviva commented on ff75341 Jun 18, 2012

Ugh...we're inheriting from Devise::PasswordsController and this was kind of surprising for us, considering it landed in a patch release.

Owner

josevalim replied Jun 18, 2012

Thanks for reporting. The patch release argument is tricky because I consider this to be a bug fix (usability bug fix).

In any case, are you inheriting from Devise::PasswordsController for which reason? I would not recommend inheriting from it in order to add behavior (unless you want to customize the existing one).

I can't say much about why we're using our own controller, since I haven't been involved in this part of the application. It looks like we're customizing the validation/lookup behaviour, I can only assume there was some reason behind it :).

I just thought I'd give you guys a heads up in case someone else runs into a similar problem.

Owner

josevalim replied Jun 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment