HTML5 Autofocus, to make things nicer #2037

Merged
merged 5 commits into from Aug 22, 2012

Conversation

Projects
None yet
4 participants
Contributor

Radagaisus commented Aug 21, 2012

Autofocus will make everything just a bit more pleasant for the user who needs to type his info yet again. I usually forget to add this to my views, and there's no reason for this not to come bundled from the get go.

This pull request fails (merged d169ef3 into 33fac7f).

Contributor

Radagaisus commented Aug 21, 2012

Here you go Travis, stop yelling at me.

Collaborator

carlosantoniodasilva commented Aug 21, 2012

I think there's no need for {}. Thanks.

This pull request passes (merged be2b481 into 33fac7f).

This pull request passes (merged 4962fbc into 33fac7f).

Owner

josevalim commented Aug 22, 2012

Could you also please add the autofocus option to the views defined here:

https://github.com/Radagaisus/devise/tree/4962fbcb512a436340b448c0df1e91d88b51139a/lib/generators/templates/simple_form_for

Thanks!

Contributor

Radagaisus commented Aug 22, 2012

Some of the views in simple_form_for already had autofocus.

This pull request passes (merged 422bf89 into 33fac7f).

josevalim merged commit eb51d03 into plataformatec:master Aug 22, 2012

1 check passed

default The Travis build passed
Details
Owner

josevalim commented Aug 22, 2012

merged thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment