Separates sign_up and sign_in on Registration #2111

Merged
merged 2 commits into from Oct 23, 2012

Projects

None yet

3 participants

@pootsbook
Contributor

See #2104

Completed with the help of @rubynortheast

/cc @bluemont

@josevalim josevalim and 1 other commented on an outdated diff Oct 23, 2012
lib/devise/controllers/helpers.rb
@@ -93,6 +93,12 @@ def signed_in?(scope=nil)
end
end
+ # Signs in a user on sign up. This helper delegates to sign_in and separates
@josevalim
josevalim Oct 23, 2012 Member

Thanks! Just a quick note: can we move this to the registrations_controller? The Devise::Controllers::Helpers only holds helpers that make sense through the whole application (like authentication, where which controller wants to dictate how it work).

@pootsbook
pootsbook Oct 23, 2012 Contributor

@josevalim moved sign_up to registrations_controller as requested. Also removed the test from helpers_test.

@josevalim josevalim merged commit f796439 into plataformatec:master Oct 23, 2012

1 check passed

default The Travis build passed
Details
@bluemont

Thanks so much! You got this fixed quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment