Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Extract get_message #2366

Merged
merged 2 commits into from Apr 14, 2013

Conversation

Projects
None yet
3 participants
Contributor

hauleth commented Apr 6, 2013

It will allow to get message when creating AJAX responses instead
manually searching for needed one.

@lucasmazza lucasmazza and 1 other commented on an outdated diff Apr 6, 2013

app/controllers/devise_controller.rb
@@ -164,12 +164,16 @@ def successfully_sent?(resource)
# Please refer to README or en.yml locale file to check what messages are
# available.
def set_flash_message(key, kind, options={})
+ flash[key] = get_message(kind, options) if message.present?
@lucasmazza

lucasmazza Apr 6, 2013

Owner

This if is breaking the test suite since message isn't defined anywhere. Could you take a look? (I guess your intention was to assign the get_message return value to a message variable or something like that?)

@hauleth

hauleth Apr 6, 2013

Contributor

Yeah of course. Too late for me. I will fix that in a second.

@hauleth

hauleth Apr 7, 2013

Contributor

Done

Owner

josevalim commented Apr 14, 2013

@lucasmazza feel free to merge it if you think it is ready!

@lucasmazza lucasmazza added a commit that referenced this pull request Apr 14, 2013

@lucasmazza lucasmazza Merge pull request #2366 from hauleth/extract-lookup-for-i18n
Extract get_message
93013c2

@lucasmazza lucasmazza merged commit 93013c2 into plataformatec:master Apr 14, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment