Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix visibility of attributes under ruby 1.9 on v1.0 branch #13

Closed
wants to merge 2 commits into from

3 participants

George Ogata Rafael Mendonça França José Valim
George Ogata

On the v1.0 branch, the attributes generated were protected since #attribute itself was protected.

If you're no longer interested in taking patches for v1.0, let me know and I'll maintain my own fork.

josevalim and others added some commits
José Valim josevalim Give version when installing. d405a3f
George Ogata oggy Ensure attribute accessors are public.
In Ruby 1.9, the accessors were protected since #attribute itself is
protected.
0749145
Rafael Mendonça França

Hey sorry for the delay. We are not maintain the 1.0 branch, but I guess you are maintain you own fork. But thanks to send you pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 24, 2009
  1. José Valim
Commits on Dec 30, 2011
  1. George Ogata

    Ensure attribute accessors are public.

    oggy authored
    In Ruby 1.9, the accessors were protected since #attribute itself is
    protected.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 1 deletion.
  1. +1 −1  README.rdoc
  2. +2 −0  lib/mail_form/dsl.rb
2  README.rdoc
View
@@ -34,7 +34,7 @@ It's tested and compatible with Rails 2.2.x and Rails 2.3.x.
Install MailForm is very easy. It is stored in Gemcutter, so just run the following:
- sudo gem install mail_form
+ sudo gem install mail_form --version=1.0.0
If you want it as plugin, just do:
2  lib/mail_form/dsl.rb
View
@@ -42,6 +42,8 @@ def attribute(*accessors)
options = accessors.extract_options!
attr_accessor *accessors
+ public *accessors
+ public *accessors.map{|s| "#{s}="}
if options[:attachment]
write_inheritable_array(:form_attachments, accessors)
Something went wrong with that request. Please try again.