test against actionmailer 3.0, 3.1, 3.2, 4.0 #23

Merged
merged 3 commits into from Mar 25, 2013

2 participants

@nashby
  • use public API method for running callbacks (it's actually #22 but without block that we do not need I guess)
@rafaelfranca rafaelfranca commented on an outdated diff Mar 23, 2013
gemfiles/Gemfile-rails.3.0.x
@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gemspec

You need to specify the path of the gemspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rafaelfranca rafaelfranca commented on an outdated diff Mar 23, 2013
gemfiles/Gemfile-rails.3.1.x
@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gemspec

You need to specify the path of the gemspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rafaelfranca rafaelfranca commented on an outdated diff Mar 23, 2013
gemfiles/Gemfile-rails.3.2.x
@@ -0,0 +1,9 @@
+source 'https://rubygems.org'
+
+gemspec

You need to specify the path of the gemspec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rafaelfranca rafaelfranca and 1 other commented on an outdated diff Mar 25, 2013
lib/mail_form/notifier.rb
@@ -1,5 +1,18 @@
module MailForm
class Notifier < ActionMailer::Base
+ # since ActionMailer 3.0 has own simple_format method
+ # but we need one from the ActionPack
+ # https://github.com/rails/rails/commit/fb34f8577c47d958ca32b7ab585c1904e1a776b1
+ helper do
+ def simple_format(text, html_options={}, options={})
+ Class.new do

We are creating a new class every time this method is called. I think is better to memoize it

@nashby
nashby added a note Mar 25, 2013

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@rafaelfranca rafaelfranca merged commit 9dbc441 into plataformatec:master Mar 25, 2013

1 check passed

Details default The Travis build passed
@nashby nashby deleted the nashby:gemfiles branch Mar 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment