New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: flag to remove comments from controller #41

Closed
jackdempsey opened this Issue Apr 18, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@jackdempsey

jackdempsey commented Apr 18, 2012

I always delete those comments and it seems like a waste to fork/clone responders just to add some touchups like that. Would you consider a patch that allows removing the comments? (or even easier, any chance you're cool with just removing the comments? The main rails scaffolds are for learning, but if someone's using responders I assume they know what the actions are doing. Thoughts?

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Apr 18, 2012

Collaborator

I think we can remove it. 👍

Collaborator

rafaelfranca commented Apr 18, 2012

I think we can remove it. 👍

@jackdempsey

This comment has been minimized.

Show comment
Hide comment
@jackdempsey

jackdempsey Apr 18, 2012

Excellent! Happy to provide a patch, tho you're probably done by this point :-D

jackdempsey commented Apr 18, 2012

Excellent! Happy to provide a patch, tho you're probably done by this point :-D

@rafaelfranca

This comment has been minimized.

Show comment
Hide comment
@rafaelfranca

rafaelfranca Apr 18, 2012

Collaborator

I like to see what @josevalim and @carlosantoniodasilva have to say about it before do anything. But if we decide to remove it, we will ask you to provide a patch. xD

Collaborator

rafaelfranca commented Apr 18, 2012

I like to see what @josevalim and @carlosantoniodasilva have to say about it before do anything. But if we decide to remove it, we will ask you to provide a patch. xD

@josevalim josevalim closed this in 1b364cf Apr 18, 2012

@jackdempsey

This comment has been minimized.

Show comment
Hide comment
@jackdempsey

jackdempsey Apr 18, 2012

You're a champ @josevalim ty sir!

jackdempsey commented Apr 18, 2012

You're a champ @josevalim ty sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment